refactor(auth): replace use of deprecated ErrOTPRequired
#1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
changed the title
ErrOTPRequired
EtienneM
force-pushed
the
fix/go-scalingo/360/ErrOTPRequired_duplication
branch
from
ba73dcc
to
7dade04
Compare
EtienneM
commented
Sep 18, 2023
| @@ -11,12 +11,12 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/pkg/errors" | |||
| errgo "gopkg.in/errgo.v1" | |||
There was a problem hiding this comment.
I removed this dependency from this file and it had a lot of side effects, sorry.. 😅
EtienneM
force-pushed
the
fix/go-scalingo/360/ErrOTPRequired_duplication
branch
3 times, most recently
from
c3148c3
to
2d32d21
Compare
EtienneM
force-pushed
the
fix/go-scalingo/360/ErrOTPRequired_duplication
branch
from
2d32d21
to
5dde6ad
Compare
ipfaze
requested changes
Sep 21, 2023
config/auth.go
Outdated
| @@ -43,7 +43,7 @@ func Auth(ctx context.Context) (*scalingo.User, string, error) { | |||
| if err == nil { | |||
| break | |||
| } else if scalingoerrors.RootCause(err) == io.EOF { | |||
There was a problem hiding this comment.
issue(non-blocking): Can you change the deprecated function .RootCause() to the function .Is()
| @@ -11,12 +11,12 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/pkg/errors" | |||
There was a problem hiding this comment.
suggestion: Is it possible to replace all existing errors to scalingoerrors?
It will freed us from the use of another deprecated package
There was a problem hiding this comment.
It's not possible. We declare some public variable, for instance on line 24:
var (
ErrAuthenticationFailed = errors.New("authentication failed")
)scalingoerrors requires a context and we have no context available here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Scalingo/go-scalingo#360
Fix Scalingo/go-scalingo#324
Fix Scalingo/go-scalingo#326