Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrOTPRequired is declared twice #360

Closed
EtienneM opened this issue Sep 18, 2023 · 0 comments · Fixed by #361
Closed

ErrOTPRequired is declared twice #360

EtienneM opened this issue Sep 18, 2023 · 0 comments · Fixed by #361
Assignees
@EtienneM
Labels
low quicky

Comments

@EtienneM
Copy link
Member

EtienneM commented Sep 18, 2023 •
edited
Loading

In the http package and in the go-scalingo/v6 package. We should check our codebase to see where it's used, and deprecate one of them.

I think the double declaration is just an error for the initial release of OTP in the authentication service 5 years ago, and we never noticed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EtienneM EtienneM

Labels
low quicky
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(tokens): deprecate ErrOTPRequired and IsOTPRequired Scalingo/go-scalingo
1 participant
@EtienneM