Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile and docker-compose.yaml to deploy container, and workflow to automatically build new images on master branch #654

Closed
wants to merge 3 commits into from

Conversation

DavidHenryThoreau
Copy link
Contributor

I've simplified the Dockerfile in order to reduce size, I've also create a docker-compose.yaml in order to deploy the container.
You can find in .github/workflow/docker.yaml a workflow to build docker images for arm64 and amd64.

@DavidHenryThoreau DavidHenryThoreau changed the title Dev Dockerfile and docker-compose.yaml to deploy container, and workflow to automatically build new images on master branch Nov 23, 2024
@SamR1
Copy link
Owner

SamR1 commented Dec 28, 2024

Hi,

Thanks for the PR.
It is replaced by the following PR #672.

I rebased the branch and made some changes and fix:

  • for production, only fittrackee directory is required. And there's no need to install development dependencies.
  • replace flask server with gunicorn (flask server is for development only)
  • move environment variables in a .env file
  • remove ports from docker-compose.yml for Redis and PostgreSQL containers
  • add a container dedicated to workers (same image as the web application)
  • add health checks
  • publish image to Docker Hub in addition to Github registry. Docker images are built only on tag push (release workflow)

@SamR1 SamR1 closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants