-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input improvements #462
Input improvements #462
Conversation
…t and EnableTime == false
…bleTime is false, and should compare dates and times if EnableTime is true
Congratulations 🎉. DeepCode analyzed your code in 0.001 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard |
…ble primitive types Resolves SamProf#365
I just saw the comment from @fire-birdie that "I ran into this problem while trying to bind MatNumericUpDownField to an int? field. Looking at the 2.0.0 release notes makes it seem like the decision to omit support for non-decimal nullable types was intentional, but I can't figure out why. I'll prepare a PR to add support for the other primitive types, I just hope it doesn't break anything..." I needed int? support as well, so I merged that PR. If it causes problems, can we just keep int? support without breaking other things? |
…remediate some vulnerabilities revealed through audit
Thanks for contributing Ron!! |
I'm trying to get to production quality on inputs and tables. More to come! |
I just made the last update to this PR. I was going to make separate PRs, but then I realized that the updates built on each other, so it was easier to just update this branch. Feel free to review and merge. |
I am ill, in a 1-3 days I will return =) |
Thank you for your big contribution! |
Thank you for this great repo! It has been very useful to me, so the least I can do is contribute back. |
@RonPeters Please fill out a comment on this issue: #474 I think you might be a contributor. |
Thank you. Visually it's good job. |
@SamProf Thanks, I was just about to merge the conflicts. |
I haven't seen @SamProf on here in at least 2 weeks. I hope all is well.
I will just keep adding my commits to this pull request until there is more merge activity on this repo.