Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input improvements #462

Merged
merged 11 commits into from
Mar 31, 2020
Merged

Input improvements #462

merged 11 commits into from
Mar 31, 2020

Conversation

RedFolder
Copy link
Contributor

@RedFolder RedFolder commented Mar 18, 2020

I haven't seen @SamProf on here in at least 2 weeks. I hope all is well.

I will just keep adding my commits to this pull request until there is more merge activity on this repo.

  • MatIconButton - Added OnClickStopPropagation
  • MatButton - Added OnClickStopPropagation
  • MatDatePicker - Do not display the time in the text field by default. Respect the Format and EnableTime parameters.
  • MatDatePicker - Fixed the labeling of the DisableMobile Demo
  • MatDatePicker - Fixed Minimum and Maximum implementation by comparing only dates if EnableTime is false, and comparing dates and times if EnableTime is true
  • MatNumericUpDownField - Added FieldType parameter with Numeric, Currency, and Percent types. Percent was needed as a special implementation because the .NET percent format string multiplies the value by 100. This means 0.45 displays as 45%. So I had to hook into the parsing so that when you entered "45", it was converted to the value 0.45. Updated the demo to reflect the new FieldType
  • MatBlazorSwitchT - Merged PR Add MatBlazorSwitchT implementations for nullable primitive types Resolves #365 #449 [Add MatBlazorSwitchT implementations for nullable primitive types Resolves MatBlazorSwitchT - Missing some implementations for nullable types #365]
  • package.json - Fixed invalid structure and updated some packages to address some of the vulnerabilities identified in audit

@ghost
Copy link

ghost commented Mar 18, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.001 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@RedFolder
Copy link
Contributor Author

RedFolder commented Mar 18, 2020

I just saw the comment from @fire-birdie that "I ran into this problem while trying to bind MatNumericUpDownField to an int? field. Looking at the 2.0.0 release notes makes it seem like the decision to omit support for non-decimal nullable types was intentional, but I can't figure out why. I'll prepare a PR to add support for the other primitive types, I just hope it doesn't break anything..."

I needed int? support as well, so I merged that PR. If it causes problems, can we just keep int? support without breaking other things?

…remediate some vulnerabilities revealed through audit
@enkodellc
Copy link
Collaborator

Thanks for contributing Ron!!

@RedFolder
Copy link
Contributor Author

I'm trying to get to production quality on inputs and tables. More to come!

@RedFolder
Copy link
Contributor Author

I just made the last update to this PR. I was going to make separate PRs, but then I realized that the updates built on each other, so it was easier to just update this branch. Feel free to review and merge.

@SamProf
Copy link
Owner

SamProf commented Mar 30, 2020

I am ill, in a 1-3 days I will return =)

@SamProf
Copy link
Owner

SamProf commented Mar 30, 2020

Thank you for your big contribution!
I need time to check this PR. I think tomorrow I will check and will make new release with this changes

@RedFolder
Copy link
Contributor Author

Thank you for this great repo! It has been very useful to me, so the least I can do is contribute back.

@enkodellc
Copy link
Collaborator

@RonPeters Please fill out a comment on this issue: #474 I think you might be a contributor.

@SamProf
Copy link
Owner

SamProf commented Mar 31, 2020

Thank you. Visually it's good job.
can you fix merge conflicts here?
'
src/MatBlazor.Demo/Demo/DemoMatTextField.razor
src/MatBlazor.Demo/Demo/DemoNumericUpDownField.razor
'

@SamProf SamProf merged commit dfa896e into SamProf:master Mar 31, 2020
SamProf added a commit that referenced this pull request Mar 31, 2020
@RedFolder
Copy link
Contributor Author

@SamProf Thanks, I was just about to merge the conflicts.

@RedFolder RedFolder deleted the input-improvements branch April 2, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatBlazorSwitchT - Missing some implementations for nullable types
4 participants