Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors team #474

Open
SamProf opened this issue Mar 30, 2020 · 34 comments
Open

Contributors team #474

SamProf opened this issue Mar 30, 2020 · 34 comments

Comments

@SamProf
Copy link
Owner

SamProf commented Mar 30, 2020

Hey!

I have started MatBlazor just for fun as pet project, because I really interested in Blazor.
Now, MatBlazor - one most popular library for Blazor.
I feel that sometimes it's hard for me to be alone.
I like to spend a time to create new components and big features. But many bugs still open and I can not manage all this things.
Also MatBlazor - not only development. For example - documentation and manuals is very important, but my English and writer skills - "can be better". And also there are other many things that should be done...
@enkodellc helps me a lot from early time of creation, and I want to say - thank you.
But many other contributors create big investment in MatBlazor - thank you too.

I want to ask. Maybe someone feel that he want and can to be contributor of MatBlazor project?
Contribution can be any type - development, bugs and PR checking, documentation, manuals, funding, marketing, relations and etc...
I think it can be good experience for many peoples.

And of course question - how MatBlazor and I can help you?

@SamProf SamProf pinned this issue Mar 30, 2020
@enkodellc
Copy link
Collaborator

I want to thank @SamProf for creating and continual development of MatBlazor. I would like to be added as a contributor to help test & merge existing PR's, as well as answer issues and questions.

I will take responsibility for the [MatNavMenu, MatToast], their Issues, Documentation, and Examples. I also started MatTable but @SamProf is rewriting it as mine was fairly basic to start.

I do not have any ambitions at the moment for new components at this time and would discuss any new ideas with @SamProf.

MatBlazor helps me because I have built https://github.com/enkodellc/blazorboilerplate with it and want to continue to grow Blazor Boilerplate with MatBlazor.

May main focus will always be Blazor Boilerplate but since that includes MatBlazor I will be making time for it as well.

@lindespang
Copy link
Collaborator

Thank you @SamProf for your hard work and dedication to this repo!

Just as @enkodellc I don't really have any ambition to invent something new to MatBlazor (but is certainly available if you want to discuss anything new!)

I would like to be added as a contributor to help you with "cleaning up" the repository:

  • Giving feedback on issues and PR - rejecting a PR that doesn't work out is better than be silent!
  • Closing outdated issues
  • Answering incoming issues with support or bug fixes
  • Documentation where needed

... and other things you want me to do! Just @ me and I'll help MatBlazor out!

MatBlazor helps me because I'm introducing it to my company and will probably release a small product utilizing MatBlazor this fall! So I will be working with MatBlazor almost daily which I think will be very benifical to the repository! Small bugs and quirks will be found in the QA and I can help adress these in this repo! Also, if this product is a success MatBlazor will promote itself within the company... And I think it will!

@RedFolder
Copy link
Contributor

I could not have gotten as far this quickly with my current project without the hard work @SamProf has put into MatBlazor. So thank you very much!

We are releasing our product next month and I make extensive use of MatBlazor. I have already contributed a few things that I believe helps make MatBlazor production-quality, and plan on making many more contributions to the project.

So I would also like to join as a contributor. I can immediately contribute to form fields, tables, and autocomplete. I also have plans to create a ComboBox control and would be happy to add it as an official control.

I can also assist with bugs, PRs, and releases if needed.

Thanks again @SamProf and keep up the great work!

@esso23
Copy link
Contributor

esso23 commented Apr 1, 2020

Hello,
I also want to say thanks to all the contributors of this repo. Thanks to MatBlazor I was able to start porting our React.js project to my favorite environmnent (.NET :).

I am currently considering some PRs, but I'm a little confused as how do things work in the repo. Some small "contribution guide" would be a nice addition to the main wiki page.

@SamProf
Copy link
Owner Author

SamProf commented Apr 1, 2020

I just want to add to this discussion few contributors:
@ctrl-alt-d
@ebekker
@sandrohanea
@sprotty
@EugeneShmakovCode

@ebekker
Copy link
Contributor

ebekker commented Apr 1, 2020

Just wanted to echo everyone's appreciation and gratitude. We're still only exploring and experimenting with Blazor at my job, but almost certainly will be taking advantage of MatBlazor once more concrete projects are spun up. Of course any enhancements or additions that we make to the project components will be contributed back to the community.

We are also experimenting with various other components that may not be directly within the suite of MatBlazor but may complement or work alongside, such as this wrapper over a data grid.

@sandrohanea
Copy link
Contributor

Hi all! It's nice to see how big and powerful this community has been growing around MatBlazor and I want to congratulate you all, especially @SamProf for all the effort you made to sustain this library. I'd like to contribute again and in order to do this, I'm taking a look at the great changes you made since I was familiar with this repo.

@sprotty
Copy link
Contributor

sprotty commented Apr 2, 2020

Hi
I've added the bones of a TreView control to the project, but it needs styling, my version currently supports, load on demand, selection, arrow keys, and I'm working on drag and drop support.

However Css is really not my thing and I've no idea about Scss... So if someone could help me out I would be most greatful. If I had a FsFiddle sample with the html and css/scss for a tree then I can re-work the code I have to use it. Currently I've based my tree on a ul/li but it could just as easily be done with div's.

@EduVencovsky
Copy link
Contributor

Hello guys,

The work that @SamProf did is really good and it's one of the reasons why I decided to use in my company project and we plan to change all components we are currently using to MatBlazor's components as this project keeps improving.

I would like to help and contribute to this repo in order to improve new components, creating new features, and also helping with issues and pull requests.

MatBlazor is awesome!

@enkodellc
Copy link
Collaborator

@SamProf hope you are doing well. Have you put any more consideration into adding collaborators?

@SamProf
Copy link
Owner Author

SamProf commented Apr 25, 2020

Hey everyone.

Thank you all for support help and contribution.
I will add today to contributors first 3 peoples. Later I will select more peoples.
But if for someone is very important to be contributor, please write me email.

@enkodellc
@lindespang
@RonPeters

Thank you.

@SamProf
Copy link
Owner Author

SamProf commented Apr 25, 2020

I think it would be good to have skype/zoom session to discuss about ideas and plans.

@lindespang
Copy link
Collaborator

@SamProf Thank you! Looking forward to future work! I think it would be a good idea to have a chat as well 👍

@enkodellc
Copy link
Collaborator

@SamProf Thanks, I can Skype / zoom most anytime. I am In Mountain Time Zone USA so please let me know when you want to connect. Like I said I do not plan on doing anything major. I can help with PR's, questions and maintaining the components I built. As we have discussed before it would be great to have a Development or Staging branch that we push PR's to for testing and you give you access to master.... something along those lines. Looking forward to working with the group. I know I have really appreciated the support I am getting on Blazor Boilerplate from my collaborators.

@RedFolder
Copy link
Contributor

@SamProf Thanks and looking forward to collaborating. I am going live with a server-side Blazor app next month and have a vested interest in MatBlazor being production quality. I am Pacific Time USA, but I'm pretty flexible regarding time to connect. I agree with @enkodellc and having a well-defined branching strategy.

@CSOleson
Copy link
Contributor

@SamProf ,
Is there a place someone can request access to contribute?

@enkodellc
Copy link
Collaborator

@CSOleson That place is on this issue :) Leave a comment to make your case. I am not sure if Vladimir is adding more but I am sure eventually he will as the project is growing.

My opinion / suggestion is to add PR's / resolve issues and answer questions on gitter. Do some things you would do as a contributor. Right now @lindespang and I are doing a lot of PR testing and reviewing issues. Definitely would like some help in this area. Also maybe some more help with the wiki.

One thing I did notice is Vladimir is adding people who have projects that use MatBlazor either in open source or professionally. I am sure this isn't a requirement but obviously is a factor. Also it wouldn't hurt to make a donation to @SamProf :)

@CSOleson
Copy link
Contributor

The reason I mainly ask is because I've run into a few things already where it would be easier for me to be able to open a PR than to write it up for someone else to fix. I reported a MatTable issue yesterday, found a few more issues later on, and they're such low hanging fruit that it would be a no brainer to fix.

I'm using MatBlazor in two projects professionally, and it's helped greatly. As I start to go further into it, our QA folks will begin to find issues and open tickets on our end to be fixed (and I can then justify fixing something within the library on occasion).

I went ahead and commented on a few of the open issues too in order to help.

Best Regards,

@lindespang
Copy link
Collaborator

lindespang commented May 24, 2020

The reason I mainly ask is because I've run into a few things already where it would be easier for me to be able to open a PR than to write it up for someone else to fix.

@CSOleson Maybe it's been a misunderstanding, but you are more than welcome to open up PR's even though you aren't a collaborator (I see the term contributor is used in this thread which is technically wrong). The difference is that someone in collaborator team must accept the merge to development - this used to take some time, but MatBlazor has picked up pace greatly in recent two months with the addition of the collaborator team.

If you submit a PR to the development branch you will get feedback very fast, and if it's good (bug fix etc) it will probably be in the next release.

@Andras-Csanyi
Copy link

Hi @SamProf and all,

I'm happy to contribute if you need some help still. I'm only a hobby developer and a former automation tester who have been walking on the manager path for a while. :) I maybe can help with adding missing examples and tests using Verify/bunit, once I wrapped my mind around it.

@CSOleson
Copy link
Contributor

The reason I mainly ask is because I've run into a few things already where it would be easier for me to be able to open a PR than to write it up for someone else to fix.

@CSOleson Maybe it's been a misunderstanding, but you are more than welcome to open up PR's even though you aren't a collaborator (I see the term contributor is used in this thread which is technically wrong). The difference is that someone in collaborator team must accept the merge to development - this used to take some time, but MatBlazor has picked up pace greatly in recent two months with the addition of the collaborator team.

If you submit a PR to the development branch you will get feedback very fast, and if it's good (bug fix etc) it will probably be in the next release.

Hmmmm, maybe I'm doing something wrong then, but it looks like I cannot even create a branch from dev and/or push to the created branch since I do not have permissions. I guess that was where I was trying to start and that I'm being denied the permissions to do so.

@lindespang
Copy link
Collaborator

You need to fork Matblazor first and then work against your own repo(your fork) until you're done and then you suggest these changes to MatBlazor repo using a pull request. This is the case for all open source repos on Github. Check out link below and get back if there are any questions!☺

https://codeburst.io/a-step-by-step-guide-to-making-your-first-github-contribution-5302260a2940

@enkodellc
Copy link
Collaborator

@CSOleson right now with MatBlazor as collaborators we have an understanding with Vladimir to push changes to "develop" branch and he will review for final say and then release to nuget. We agreed not to push to master or create further branches. I agree with @lindespang that you should create your own fork from develop. Then as each issue you find it would be best to create an issue, a new branch off of your fork and then submit a PR against the develop branch. This is how we are submitting PR's and currently are asking each other to review and open discussions on gitter if there is a any question. I am happy to hear you and others are taking more interest in MatBlazor. We will gladly do our best to help you merge PR's!

@SayusiAndo and @CSOleson If you have time to review existing issues, verify the issue still exists and is repeatable, that is a great start. Then of course if you can fix the issue it would be very beneficial. Just put a comment in the issue / PR and we will do our best to get to them.

@CSOleson
Copy link
Contributor

Thanks all for the responses!

@Andras-Csanyi
Copy link

@enkodellc I went through all the open bugs, all of them marked as bug in the last 3 weeks, but in the last three weeks there were no significant bug fixes according to the commit history. I believe, they show an accurate picture.

@adospace
Copy link

Why not open the project to Github Sponsors (https://github.com/sponsors)?
Personally I don't have much time to help nor I have much experience in blazor development but I really like the project and probably I'll use it in my future projects.
I'm willing to contribute with money to fund it so you guys have, at least partially, compensation for your great work!

@henon
Copy link
Contributor

henon commented Jun 6, 2020

I want to contribute by fixing bugs. I am looking for something easy to get to know the library.

@ericvanderwal
Copy link

Is there a place where the MatBlazor folks like to hang out? A discord, gitter or slack? It might be easier to communicate there with people who would like to contrib by PRs?

@CSOleson
Copy link
Contributor

Is there a place where the MatBlazor folks like to hang out? A discord, gitter or slack? It might be easier to communicate there with people who would like to contrib by PRs?

Check this out @dumbgamedev : https://gitter.im/MatBlazor/community

@peterthomastlc
Copy link

Hi, I'd like to thank @SamProf and everyone else responsible for putting this project together and maintaining/expanding it. I'm very new to Blazor and just finding my feet - which MatBlazor is helping greatly with.
I don't expect that I'll have a huge amount of time to devote to the project, but I'd at least like to be able to submit pull requests for fixes to any issues I may come across (I raised issue #671 today, with suggested fix attached).
If submitting pull requests requires me to be a registered contributor, could I be added to the list please?

@lindespang
Copy link
Collaborator

@peterthomastlc Everyone is welcome to submit PR's, if you need help how to do so without push access, check my earlier comment above:)

@peterthomastlc
Copy link

@lindespang, ah ok thanks - I need a fork first. Will do.

@damianog
Copy link
Contributor

@SamProf with MatBalzor you do really a great job! Do you allow new contributors? I want to start using MatBlazor in my Blazor projects but as usual some controls need addition or fix, I know that free time often gets less and less, so I would like to help to close Issues. Thanks anyway.

@enkodellc
Copy link
Collaborator

@damianog we are always trying to find to time to contribute. I am not sure if @SamProf wants to bring on more collaborators, For the current collaborators we have proven ourselves by contributing through PR's and Issues so that is what I suggest. I also recommend to get involved in the Gitter for MatBlazor. If you have questions please post to the Gitter. I personally have been only focused on reviewing PR's from other collaborator's. I do not have time to watch the issues. I look forward to seeing you in our PR's and helping make your Blazor Project a success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests