Skip to content

Pull latest changes from main#3

Merged
SakshayMahna merged 9 commits intoSakshayMahna:mainfrom
ros-navigation:main
Aug 15, 2025
Merged

Pull latest changes from main#3
SakshayMahna merged 9 commits intoSakshayMahna:mainfrom
ros-navigation:main

Conversation

@SakshayMahna
Copy link
Copy Markdown
Owner


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

mini-1235 and others added 9 commits August 8, 2025 11:07
* Add support for dynamically changing keepout zone

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Linting

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Revert binary and speed changes

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
)

* Add controller utils

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

* Fix linting issues

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

* Update regulated pure pursuit

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

* Update graceful controller

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

* Remove interpolate after goal & Use orientationAroundZAxis

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

* Update nav2_util/src/controller_utils.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_util/src/controller_utils.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_util/src/controller_utils.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Remove interpolate_after_goal parameter from test

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>

---------

Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Fix lifecycle manager deadlock during shutdown

Add stop() method to ServiceClient that cancels internal executor operations
and call it in LifecycleServiceClient destructor to prevent deadlock when
CTRL+C is pressed during lifecycle node bringup.

This addresses issue #5437 where spin_until_future_complete can hang
indefinitely during shutdown when bringup and shutdown sequences run
concurrently.

Co-authored-by: Steve Macenski <SteveMacenski@users.noreply.github.com>

* Update service_client.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Rebase

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Make linters happy

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Rename point_cloud_transport parameter

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Rebase

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Feedback

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Feedback

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

* Fix

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>

---------

Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>
* Add option to override lethal cost in keepout zone

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Linting

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Base class call

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix: adjust C++ standard and compiler flags for Apple Clang

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

* Update: Only mppi_critics target will require C++20

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

* cmake_minimum_required(VERSION 3.8) update

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

---------

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
@SakshayMahna SakshayMahna merged commit eccd83b into SakshayMahna:main Aug 15, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants