-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add travis #50
base: develop
Are you sure you want to change the base?
Add travis #50
Conversation
don't need linting
This is blocked by https://sagebionetworks.jira.com/browse/SYNPY-639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the jira is fixed this looks good to me.
I've been using pytest to run my unit tests. Are there going to be any compatibility issues? |
Short answer: yes. |
We should use |
use pytest instead of nose
add nose and pytest as dependencies
install myself
changed setuppy + path to test csv files (should pull from synapse in future) + closes #51
add requests
install requirements first, duh
@philerooski @teslajoy any idea why this would be failing getting the version number from github (but only when running on Travis)? https://travis-ci.org/Sage-Bionetworks/annotator/jobs/348357181 |
Not sure, but a couple of brainstorming-thoughts on the travis env: I'd probably try to remove pip install -r ... and leave pip install . (maybe some library dependency stack is being corrupted) |
need the |
Ran it a few more times, finally figured it out:
We need to use a Github API Token in our request in order to guarantee this call will work. |
Looking further, we might not be able to do it this way because to supply the Github auth token as an environment variable (standard way) won't work on Travis for PR builds: https://docs.travis-ci.com/user/pull-requests#Pull-Requests-and-Security-Restrictions |
I added TSD_GITHUB_TOKEN to travis via: would have to add it to global env and in code if it exists add to auth of requests.get() else just leave request as is for local users env. |
After contemplating what this code is doing, not sure it's the best way to get the version! This PR is a good example - when I install, I'm going to report that my version is whatever is the latest version in Github - but that isn't true! This code is newer than the most recent version. We need to manage the state of versions locally (in this codebase) or through git (not Github) tags, not based on previous releases. In order to get this in, I'm going to make another issue/PR to remove and change the versioning process first. |
Blocked by #88. |
Agreed! Great idea as always! |
to run tests