Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-write tests in pytest #51

Closed
kdaily opened this issue Jan 31, 2018 · 4 comments
Closed

re-write tests in pytest #51

kdaily opened this issue Jan 31, 2018 · 4 comments
Assignees
Labels

Comments

@kdaily
Copy link
Contributor

kdaily commented Jan 31, 2018

nose is in maintenance mode. Since this project is new, we should use pytest.

http://pytest.readthedocs.io/en/latest/

@kdaily kdaily mentioned this issue Jan 31, 2018
@kdaily
Copy link
Contributor Author

kdaily commented Jan 31, 2018

pytest has basic features to run nose tests. should just try to enable it and see if it works.

http://pytest.readthedocs.io/en/latest/nose.html#noseintegration

@kdaily
Copy link
Contributor Author

kdaily commented Jan 31, 2018

It does - but we have no tests that are actually running right now?

@teslajoy
Copy link
Collaborator

teslajoy commented Jan 31, 2018

I can change this simple test to pytest no problemo.

@kdaily
Copy link
Contributor Author

kdaily commented Jan 31, 2018

Great! Please also check that the test is actually running? I tried both and no tests ran:

(annotator) [kdaily@tigger annotator]$ nosetests

----------------------------------------------------------------------
Ran 0 tests in 0.535s

OK
(annotator) [kdaily@tigger annotator]$ pytest 
============================================================================ test session starts =============================================================================
platform linux2 -- Python 2.7.14, pytest-3.4.0, py-1.5.2, pluggy-0.6.0
rootdir: /home/kdaily/src/annotator, inifile:
collected 0 items                                                                                                                                                            

======================================================================== no tests ran in 6.02 seconds ========================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants