Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always handle asset path as UnionPath #1563

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Always handle asset path as UnionPath #1563

merged 1 commit into from
Oct 8, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Oct 7, 2023

Fixes #1562

Previously it was assumed to have type Directory which is not always the case.

@heinezen heinezen added lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) bugfix Restores intended behavior labels Oct 7, 2023
This was referenced Oct 7, 2023
Closed
Closed
@TheJJ TheJJ merged commit 01c1cf7 into SFTtech:master Oct 8, 2023
1 check passed
@heinezen heinezen deleted the fix/asset-path-union branch October 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) bugfix Restores intended behavior lang: python Done in Python code
Projects
openage converter
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset path type is incorrectly used
2 participants
@heinezen @TheJJ