Fix an inappropriate test expression to remove a logical short circuit #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
force-pushed
the
Inappropriate_Logic-3processor.py9361182525541201156.diff
branch
from
9ec1c80
to
09e7d26
Compare
|
Thanks for the fix. Can you do the following before we merge this?
|
munahaf
added a commit
to munahaf/openage
that referenced
this pull request
Oct 6, 2023
heinezen
added
area: assets
TheJJ
previously approved these changes
Oct 7, 2023
|
the commit for your authorship isn't pushed to this pull request's branch yet. |
|
Do you need help with any of this? |
heinezen
pushed a commit
to munahaf/openage
that referenced
this pull request
Oct 8, 2023
heinezen
pushed a commit
to munahaf/openage
that referenced
this pull request
Oct 8, 2023
heinezen
force-pushed
the
Inappropriate_Logic-3processor.py9361182525541201156.diff
branch
from
85d9636
to
9e9b279
Compare
heinezen
force-pushed
the
Inappropriate_Logic-3processor.py9361182525541201156.diff
branch
from
9e9b279
to
9422cbe
Compare
|
I've cherry picked your commit and added it to the correct branch. It should be mergeable now. |
TheJJ
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file: processor.py, the comparison of Collection length creates a logical short circuit. The length of a collection is always greater than or equal to zero. So testing that a length is less than zero is always false.
I suggested that the Collection length comparison should be done without creating a logical short circuit.
Sponsorship and Support:
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.