Merge pull request #1559 from munahaf/Inappropriate_Logic-3processor.…

…py9361182525541201156.diff Fix an inappropriate test expression to remove a logical short circuit
SFTtech · Oct 8, 2023 · 4773e70 · 4773e70
2 parents aae16d3 + 9422cbe
commit 4773e70
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/copying.md b/copying.md
@@ -147,6 +147,7 @@ _the openage authors_ are:
 | Martin                      | Starman                     | mstarman à seznam dawt cz                         |
 | Zoltán Ács                  | zoli111                     | acszoltan111 à gmail dawt com                     |
 | Trevor Slocum               | tslocum                     | trevor à rocket9labs dawt com                     |
+| Munawar Hafiz               | munahaf                     | munawar dawt hafiz à gmail dawt com               |
 
 If you're a first-time committer, add yourself to the above list. This is not
 just for legal reasons, but also to keep an overview of all those nicknames.

diff --git a/openage/convert/processor/conversion/aoc/processor.py b/openage/convert/processor/conversion/aoc/processor.py
@@ -663,7 +663,7 @@ def create_building_lines(full_data_set: GenieObjectContainer) -> None:
 
                 upgrade_effects = effect_bundle.get_effects(effect_type=3)
 
-                if len(upgrade_effects) < 0:
+                if len(upgrade_effects) == 0:
                     continue
 
                 # Search upgrade effects for the line_id