Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration test for preview #1507

Merged
merged 15 commits into from
Dec 6, 2023
Merged

feat: add integration test for preview #1507

merged 15 commits into from
Dec 6, 2023

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Nov 28, 2023 •
edited
Loading

This PR

  • Add a new package “@sap-ux-private/playwright”
  • Add simple integration test for preview. It test preview with different UI5 Versions:
    • 1.84.35
    • 1.96.22
    • 1.108.19
    • 1.111.8
    • 1.114.0
    • 1.115.0
  • Add Github Actions
  • Pave the ground for integration test for CPE on adaption project. Integration tests for CPE will follow in another PR.

@marufrasully marufrasully requested review from a team as code owners November 28, 2023 10:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2dc1f4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marufrasully marufrasully mentioned this pull request Nov 28, 2023
Closed
@marufrasully marufrasully added the preview-middleware @sap-ux/preview-middleware label Nov 28, 2023
zdravko-georgiev
zdravko-georgiev reviewed Nov 30, 2023
View reviewed changes
packages/playwright/package.json Show resolved Hide resolved
packages/preview-middleware/test/integration/preview/preview.spec.ts Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.changeset/bright-vans-add.md Show resolved Hide resolved
donal-tobin-sap
donal-tobin-sap previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be ok from a modules consumption point of view.

devinea
devinea previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module setup and pipeline setup looks good.
Changeset ✅
Private module ✅
Thanks for the updates.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

zdravko-georgiev
zdravko-georgiev approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@zdravko-georgiev zdravko-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to preview-middleware look good
Changeset is OK
Review comments addressed

One thing that is missing is assigning code owners for the new package. But this can be done also separately.

@tobiasqueck
Copy link
Contributor

No objections from my side anymore, as soon as you have your 2nd approval, you can merge.

devinea
devinea approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

@marufrasully marufrasully merged commit 338fe50 into main Dec 6, 2023
14 checks passed
@marufrasully marufrasully deleted the feat/playwright-cpe branch December 6, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasqueck tobiasqueck tobiasqueck left review comments

@devinea devinea devinea approved these changes

@zdravko-georgiev zdravko-georgiev zdravko-georgiev approved these changes

@donal-tobin-sap donal-tobin-sap donal-tobin-sap left review comments

@Jimmy-Joseph19 Jimmy-Joseph19 Awaiting requested review from Jimmy-Joseph19

Assignees
No one assigned
Labels
preview-middleware @sap-ux/preview-middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marufrasully @tobiasqueck @donal-tobin-sap @devinea @zdravko-georgiev