Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detect): Add support for Detect 10 #5224

Merged
merged 10 commits into from
Jan 17, 2025
+30 −6
Merged

feat(detect): Add support for Detect 10 #5224

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
726f1e4
Changes for detect 10 and repo change from synopsys to blackduck
jitendk Jan 8, 2025
2bdc40a
change for blakcduck
jitendk Jan 8, 2025
0c9f697
Merge branch 'master' into master
vijayanjay Jan 16, 2025
09f619a
Making detect 10 as default version
jitendk Jan 16, 2025
e8851d0
changing test file
jitendk Jan 16, 2025
fd851aa
Updated description for useDetect8 and useDetect9
jitendk Jan 17, 2025
64b6d35
added udeDetect10 field
jitendk Jan 17, 2025
64936cf
Apply suggestions from code review
CCFenner Jan 17, 2025
1508698
commiting with go generate file
jitendk Jan 17, 2025
1f73601
Removing useDetect10 flag
jitendk Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions cmd/detectExecuteScan_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 13 additions & 2 deletions resources/metadata/detectExecuteScan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@
param: container/repositoryPassword
- name: useDetect8
description:
"This flag enables the use of the supported version 8 of the Detect Script instead of v9"
"This flag enables the use of the supported version 8 of the Detect Script instead of default version"
CCFenner marked this conversation as resolved.
Show resolved Hide resolved
aliases:
- name: detect/useDetect8
type: bool
Expand All @@ -666,7 +666,7 @@
default: false
- name: useDetect9
description:
"This flag enables the use of the supported version 9 of the Detect Script instead of v8"
"This flag enables the use of the supported version 9 of the Detect Script instead of default version"
CCFenner marked this conversation as resolved.
Show resolved Hide resolved
aliases:
- name: detect/useDetect9
type: bool
Expand All @@ -675,6 +675,17 @@
- STAGES
- STEPS
default: false
- name: useDetect10
description:
"This flag enables the use of the supported version 10 of the Detect Script"
CCFenner marked this conversation as resolved.
Show resolved Hide resolved
aliases:
- name: detect/useDetect10
type: bool
scope:
- PARAMETERS
- STAGES
- STEPS
default: true

Check failure on line 688 in resources/metadata/detectExecuteScan.yaml

View workflow job for this annotation

GitHub Actions / lint 

688:22 [trailing-spaces] trailing spaces
CCFenner marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used in code, why define it here? If you would like to document the default version, I suggest to do that in the initial step description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we make useDetect9 as default then user will not be able to use detect 10 version as by default 9 version will run as always if parameter is not passed.

outputs:
resources:
- name: influx
Expand Down
Loading