feat(detect): Add support for Detect 10 #5224
Conversation
|
/it-go |
1 similar comment
|
/it-go |
|
/it-go |
CCFenner
changed the title
| @@ -664,6 +664,17 @@ spec: | |||
| - STAGES | |||
| - STEPS | |||
| default: false | |||
| - name: useDetect9 | |||
| description: | |||
| "This flag enables the use of the supported version 9 of the Detect Script instead of v8" | |||
There was a problem hiding this comment.
| "This flag enables the use of the supported version 9 of the Detect Script instead of v8" | |
| "This flag enables the use of the supported version 9 of the Detect Script instead of v10" |
Default is v10 now, please also adjust comment on useDetect8
There was a problem hiding this comment.
@CCFenner Existing comment is right as we are moving from lower to upper detect version, so the comment "This flag enables the use of the supported version 9 of the Detect Script instead of v8" should be fine.
There was a problem hiding this comment.
Maybe we should just refer to it as "the default" instead of a specific version..
This flag will only trigger v9 if v8 is not set, so it will overwrite the use of v10.
Both useDetect9 and useDetect8 are by default false, so the step uses v10. By setting one of the parameter to true, this could be overwritten.
There was a problem hiding this comment.
I have changed the description now, default version is 10 now and user may use the detect 8 or detect 9 by setting particular field as True. I hope this is fine.
There was a problem hiding this comment.
You added a new parameter, that is however not used, I would asked to remove that please or explain what the use of that is.
There was a problem hiding this comment.
I have added useDetect10 now, without that there is no way use can use the detect 10 version.
if we not use useDetect10 then we need to set old one as default as go test was failing. If we make (useDetect8 or useDetect9 ) as default then user may not be able to use detect version 10 at all.
Now user has all three version 8,9 and 10 to used where 10 is default.
| - name: useDetect10 | ||
| description: | ||
| "This flag enables the use of the supported version 10 of the Detect Script" | ||
| aliases: | ||
| - name: detect/useDetect10 | ||
| type: bool | ||
| scope: | ||
| - PARAMETERS | ||
| - STAGES | ||
| - STEPS | ||
| default: true |
There was a problem hiding this comment.
This is not used in code, why define it here? If you would like to document the default version, I suggest to do that in the initial step description.
There was a problem hiding this comment.
if we make useDetect9 as default then user will not be able to use detect 10 version as by default 9 version will run as always if parameter is not passed.
|
|
/it-go |
Description
Added the detect 10 parameter, user can use useDetect10 field to use the detect version 10 in their scan.
Change the repo name from detect.synopsys.com to detect.blackduck.com as per vendor instruction.
Changed the failErrorLevel flag from true to false as by-default.
Checklist