Skip to content

Conversation

Ryanf55
Copy link
Owner

@Ryanf55 Ryanf55 commented Jul 26, 2025

Currently failing due to two problems.

  1. https://github.com/Ryanf55/grid_map/actions/runs/16543610906/job/46788224585?pr=5
"  Finished <<< opennav_docking_core [2.12s]
  --- stderr: nav2_util
  In file included from /root/upstream_ws/src/ros-planning/navigation2/nav2_util/include/nav2_util/robot_utils.hpp:29,
                   from /root/upstream_ws/src/ros-planning/navigation2/nav2_util/src/robot_utils.cpp:25:
  /opt/ros/rolling/include/tf2_ros/tf2_ros/buffer.h:40:4: error: #warning BUFFER_HEADER_DEPRECATION [-Werror=cpp]
     40 |   #warning BUFFER_HEADER_DEPRECATION
        |    ^~~~~~~
  cc1plus: all warnings being treated as errors
  1. https://github.com/Ryanf55/grid_map/actions/runs/16543610905/job/46788224581?pr=5
/__w/grid_map/grid_map/src/grid_map/grid_map_rviz_plugin/src/GridMapVisual.cpp: In member function ‘void grid_map_rviz_plugin::GridMapVisual::computeVisualization(float, bool, bool, std::string, bool, bool, Ogre::ColourValue, bool, std::string, bool, bool, Ogre::ColourValue, Ogre::ColourValue, bool, float, float)’:
/__w/grid_map/grid_map/src/grid_map/grid_map_rviz_plugin/src/GridMapVisual.cpp:139:30: error: ‘const grid_map::Matrix’ {aka ‘const class Eigen::Matrix<float, -1, -1>’} has no member named ‘minCoeffOfFinites’
139 |     minIntensity = colorData.minCoeffOfFinites();
    |                              ^~~~~~~~~~~~~~~~~
/__w/grid_map/grid_map/src/grid_map/grid_map_rviz_plugin/src/GridMapVisual.cpp:140:30: error: ‘const grid_map::Matrix’ {aka ‘const class Eigen::Matrix<float, -1, -1>’} has no member named ‘maxCoeffOfFinites’
[140](https://github.com/ANYbotics/grid_map/actions/runs/16536160500/job/46770970365?pr=523#step:6:141) |     maxIntensity = colorData.maxCoeffOfFinites();
    |                              ^~~~~~~~~~~~~~~~~
gmake[2]: *** [CMakeFiles/grid_map_rviz_plugin.dir/build.make:114: CMakeFiles/grid_map_rviz_plugin.dir/src/GridMapVisual.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:140: CMakeFiles/grid_map_rviz_plugin.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

The 2nd errors seems caused by the changes to eigen plugins, because those functions are defined in the plugin.
FYI @bperseghetti and @msplr

@msplr
Copy link

msplr commented Aug 5, 2025

Hi @Ryanf55

Thanks for following up!

The first issue around BUFFER_HEADER_DEPRECATION looks unrelated.

The second one is likely due to incorrect use of ament_target_dependencies() in grid_map_ros.

The dependencies that are also passed on to downstream dependencies that link against the library (like grid_map_rviz_plugin) should be set as PUBLIC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants