[ROS2] Restrict Eigen plugin definitions to only targets linking against grid_map_core #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msplr
commented
Apr 30, 2025
| @@ -127,6 +130,4 @@ endif() | |||
|
|
|||
| ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET) | |||
| ament_export_dependencies(Eigen3) | |||
| ament_package(CONFIG_EXTRAS | |||
| cmake/${PROJECT_NAME}-extras.cmake | |||
There was a problem hiding this comment.
The cmake extras should not be needed, since the public target_compile_definitions will be propagated to all dependencies.
|
Thanks, looks good. Rolling is perfect. |
|
This seemed to introduce problems in the build. Help is needed. I don't have enough time to chase the new failures down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #382 such that the Eigen plugin include paths are only defined for targets linking against grid_map_core.
I manually tested this in a dummy package with two executables, where only one is linking against grid_map_core.
@Ryanf55 Should this fix target rolling and/or jazzy?