-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to a new nightly version #288
Conversation
This comment has been minimized.
This comment has been minimized.
Looks like the ppc builder is unhappy here. |
Yeah, seems like there's still something going wrong after LLVM 12. Only tested x86_64 locally so there was a good chance that one of the other platforms miscompiles. Will try to take a look at the failure. |
Thanks!
…On Sat, May 22, 2021 at 11:27 AM Boris-Chengbiao Zhou ***@***.***> wrote:
Yeah, seems like there's still something going wrong after LLVM 12. Only tested x86_64 locally so there was a good chance that one of the other platforms miscompiles. Will try to take a look at the failure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Thanks a lot for rust-lang/rust#85276 -- I mentioned in the last informal meeting we still had relocations going on but did not have time to look into what was going on, so it is great to see that being solved. For the CI failure, I would suggest giving a quick try at disabling optimizations in the Hacking menu to discard LLVM opt issues. |
Follow up PR to fix ppc: rust-lang/rust#85700 Thanks so much for chasing down this details! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like there's a new clippy error. |
This comment has been minimized.
This comment has been minimized.
Apparently |
Good catch, created issue. |
Includes rust-lang/rust#83592, rust-lang/rust#85276 and rust-lang/rust#85700 which are needed to build correctly again after rustc's upgrade to LLVM 12. Signed-off-by: Boris-Chengbiao Zhou <[email protected]>
Review of
|
Removed the clippy fix from the commit message again since #319 took care of that. |
Yes! |
Includes rust-lang/rust#83592 and rust-lang/rust#85276 which were needed
to build correctly again after rustc's upgrade to LLVM 12.
Fixes #135.