Skip to content

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Aug 22, 2025

this is expected to fail
(EDIT(@eddyb): took a stab at the ggt.py migration, and pushed my own commits to this PR)

The generate_grammar_tables.py script was replaced with a new ggt.py script that takes vastly different arguments, thus our cargo run -p generate binary to generate cpp headers from xml spec and such needs to be adjusted to this new script.

@eddyb
Copy link
Member

eddyb commented Sep 19, 2025

Looks like this series of pull requests is responsible:

The change itself is interesting to me (I wonder if they figured out a similar trick to what I used in SPIR-T, taking advantage of the pattern in which Khronos assigns "standard" vs "vendor" enums etc.).

But in terms of the build script changes, I'll try to make sense of Android.mk, though the more I look at it, source/CMakeLists.txt, BUILD.gn, BUILD.bazel+build_defs.bzl and Android.mk all look like they duplicate the same build system changes, and I'm not even sure any of them are auto-generated from any others.

EDIT: that worked out, it's mostly removals with one monolithic invocation being added, and it's literally copy-pasteable out of Android.mk, just needing $(FOO) to turn into {FOO} for format!.

@eddyb eddyb marked this pull request as ready for review September 19, 2025 05:54
Copy link
Member

@eddyb eddyb Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish GitHub could render at least tiny hex diffs, because I used a hex editor to change the byte at position 5, from 0x00 to 0x03, and confirmed the SPIR-V 1.0 -> SPIR-V 1.3 effect that had, by running spirv-dis.

EDIT: diffing the output of xxd before/after this change:

@@ -1,4 +1,4 @@
-00000000: 0302 2307 0000 0100 0000 0f00 3900 0000  ..#.........9...
+00000000: 0302 2307 0003 0100 0000 0f00 3900 0000  ..#.........9...

@eddyb eddyb merged commit 64ad517 into main Sep 19, 2025
6 checks passed
@eddyb eddyb deleted the vulkan-sdk-1.4.321 branch September 19, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants