Use compressed tables for extended instructions #6135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
approved these changes
May 7, 2025
dneto0
force-pushed
the
extended-inst-table
branch
from
73f1d98 to
74a8dd8
Compare
dj2
approved these changes
May 7, 2025
Also: - spv_context no longer contains tables. - AssemblyGrammar is never invalid anymore, so remove its isValid method. - Remove unused uses of AssemblyGrammar, e.g. in the disassembler. - Remove unused parameters - Fix buildifier advice - macros should have a name keyword argument, by convention - functions should have docstrings Bug: crbug.com/413723831 Co-authored-by: alan-baker <[email protected]>
dneto0
force-pushed
the
extended-inst-table
branch
from
74a8dd8 to
f469e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
spv_context no longer contains tables.
AssemblyGrammar is never invalid anymore, so remove its isValid method.
Remove unused uses of AssemblyGrammar, e.g. in the disassembler.
Remove unused parameters
Fix buildifier advice
Bug: crbug.com/413723831