Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data page loading #1369

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix data page loading #1369

merged 1 commit into from
May 24, 2023

Conversation

likawind
Copy link
Contributor

@likawind likawind commented May 24, 2023

Describe your changes and why you are making these changes

This PR fixes data page crash by adding proper changes that should have been introduced in #1345

Related issue number (if any)

ENG-3041

Loom demo (if any)

  • Verified data page is working
    Screenshot 2023-05-24 at 1 06 44 PM

  • Verified workflow list page does not have any regressions

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind requested review from agiron123 and eunice-chan May 24, 2023 18:35
Copy link
Contributor

@eunice-chan eunice-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you add a screenshot of the data page?

@likawind likawind merged commit 7b21561 into rc_v034 May 24, 2023
@likawind likawind deleted the eng-3041-fix-data-page-loading branch May 30, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants