-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 2736 Use V2 Routes for Workflows Page #1345
Merged
eunice-chan
merged 25 commits into
main
from
eng-2736-m3-todo-update-content-use-v2-routes-for
May 20, 2023
Merged
Eng 2736 Use V2 Routes for Workflows Page #1345
eunice-chan
merged 25 commits into
main
from
eng-2736-m3-todo-update-content-use-v2-routes-for
May 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate-metric-and-check-routes
…reate-metric-and-check-routes
…aqueducthq/aqueduct into eng-2736-m3-todo-update-content-use-v2-routes-for
eunice-chan
added
the
skip_integration_test
Skips required integration test (only documentation/UI changes)
label
May 19, 2023
agiron123
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Use V2 Routes for Workflows Page
Related issue number (if any)
ENG 2736
Loom demo (if any)
Search, sort, pagination.
Screen.Recording.2023-05-19.at.10.41.04.AM.mov
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)