eng-2888-investigate-resource-edit-bug #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t item box styling. (#1258) Co-authored-by: Andre Giron <[email protected]>
Co-authored-by: Andre Giron <[email protected]>
…ces page after deleting a resource. Also fixes lint
…le confirm button after completing form
eunice-chan
added
the
skip_integration_test
jpurusho65
approved these changes
May 3, 2023
kenxu95
approved these changes
May 3, 2023
kenxu95
force-pushed
the
backend-eng-2864-update-the-workflows-section-of-the
branch
2 times, most recently
from
e01e703 to
3d08e03
Compare
Base automatically changed from
backend-eng-2864-update-the-workflows-section-of-the
to
ui_reframing
May 3, 2023 06:33
eunice-chan
changed the title
eunice-chan
force-pushed
the
eng-2888-investigate-resource-edit-bug
branch
from
1ff5a60 to
6174ca5
Compare
|
@eunice-chan can you also add the |
…queducthq/aqueduct into eng-2888-investigate-resource-edit-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Can edit Postgres integration name now.
The issue is that none of the Config models have an
exec_statefield and we do not allow extra fields so pydantic throws an error when trying to convert the json.Not sure who has context regarding why there is an
exec_statefield. Once we have more information, we can update this PR so that we can either remove that field from the spec or update the model to expect it (not optional field).Related issue number (if any)
ENG 2888
ENG 2864
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)