Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2862, ENG-2863 Fix broken sidebar styling and add integration list item box styling. #1258

Merged

Conversation

agiron123
Copy link
Contributor

Describe your changes and why you are making these changes

This PR fixes broken sidebar styling around Aqueduct logo and box sizing issue with AddIntegration list items.

Related issue number (if any)

ENG-2862

Loom demo (if any)

Screenshot:
image

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 27, 2023
@agiron123 agiron123 requested a review from kenxu95 April 27, 2023 22:59
@agiron123 agiron123 changed the title ENG-2862 Fix broken sidebar styling and add integration list item box styling. ENG-2862, ENG-2863 Fix broken sidebar styling and add integration list item box styling. Apr 27, 2023
@agiron123 agiron123 merged commit 92b788b into ui_reframing Apr 27, 2023
@agiron123 agiron123 deleted the eng-2862-fix-the-broken-ui-components-on-the branch April 27, 2023 23:11
kenxu95 pushed a commit that referenced this pull request May 1, 2023
kenxu95 pushed a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants