Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2639 Postgres Periodic Integration Tests #1135

Merged
merged 9 commits into from
Apr 6, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Mar 24, 2023

Describe your changes and why you are making these changes

This PR sets up periodic integration tests to run tests against Postgres.

Setup here is a little different than I expected due to the way that Github Actions handles networking.

Followed a tutorial here and was able to get a Postgres service up and running:
https://josef.codes/using-a-real-postgres-database-in-your-github-ci-pipeline/

Related issue number (if any)

ENG-2639

Loom demo (if any)

N/A (see actions tab here 😄 )

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the run_integration_test Triggers integration tests label Mar 24, 2023
@agiron123 agiron123 requested a review from kenxu95 March 24, 2023 20:45
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still WIP, can bump this off my review queue until Andre is back. It's not something we desperately need to get in this week.

@agiron123 agiron123 force-pushed the eng-2639-add-automated-periodic-testing-coverage branch from a4b2f1b to bd6c34f Compare April 3, 2023 23:34
@agiron123
Copy link
Contributor Author

agiron123 commented Apr 4, 2023

@kenxu95 Checks here are passing. Going to update to run on schedule again and will set the test-config file to use the test-config.yml before merging.

image

@agiron123 agiron123 force-pushed the eng-2639-add-automated-periodic-testing-coverage branch from 6eacabf to 212c789 Compare April 6, 2023 17:38
@agiron123 agiron123 merged commit 69dd699 into main Apr 6, 2023
@agiron123 agiron123 deleted the eng-2639-add-automated-periodic-testing-coverage branch April 6, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants