Skip to content

Commit

Permalink
Removes logs and updates workflow configuration to get ready for prod.
Browse files Browse the repository at this point in the history
  • Loading branch information
Andre Giron committed Apr 6, 2023
1 parent 70e4dde commit 212c789
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 25 deletions.
39 changes: 18 additions & 21 deletions .github/workflows/periodic-integration-tests.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Periodic Integration Tests

on:
push:
branches:
- "eng-2639-add-automated-periodic-testing-coverage"
schedule:
- cron: "0 12 * * 1-5" # Run at 4AM PST on every weekday
workflow_dispatch:
Expand Down Expand Up @@ -155,21 +152,21 @@ jobs:
run: python3 teardown_hosted.py --aws-key-id ${{ secrets.SAURAV_AWS_ACCESS_KEY_ID }} --aws-secret-key ${{ secrets.SAURAV_AWS_SECRET_ACCESS_KEY }}

# Sets it as an environmental variable.
# - name: Get the Slack ID for the current oncall
# if: always()
# run: |
# aws s3 cp s3://aqueduct-assets/oncall.yml ./oncall.yml
# echo "ONCALL_SLACK_MEMBER_ID=$(python3 scripts/get_current_oncall.py --file ./oncall.yml)" >> $GITHUB_ENV

# - name: Report to Slack on Failure
# if: always()
# uses: ravsamhq/notify-slack-action@v1
# with:
# status: ${{ job.status }}
# notification_title: ""
# message_format: "{emoji} *{workflow}* has {status_message}"
# footer: "{run_url}"
# notify_when: "failure,warnings"
# mention_users: ${{ env.ONCALL_SLACK_MEMBER_ID }}
# env:
# SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
- name: Get the Slack ID for the current oncall
if: always()
run: |
aws s3 cp s3://aqueduct-assets/oncall.yml ./oncall.yml
echo "ONCALL_SLACK_MEMBER_ID=$(python3 scripts/get_current_oncall.py --file ./oncall.yml)" >> $GITHUB_ENV
- name: Report to Slack on Failure
if: always()
uses: ravsamhq/notify-slack-action@v1
with:
status: ${{ job.status }}
notification_title: ""
message_format: "{emoji} *{workflow}* has {status_message}"
footer: "{run_url}"
notify_when: "failure,warnings"
mention_users: ${{ env.ONCALL_SLACK_MEMBER_ID }}
env:
SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
4 changes: 0 additions & 4 deletions integration_tests/sdk/setup_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,7 @@ def _setup_external_sqlite_db(path: str):


def _setup_postgres_db():
print("Installing Aqueduct Postgres Connector")
_execute_command(["aqueduct", "install", "postgres"])
print("Finished installing Postgres Connector")


def _setup_relational_data(client: Client, db: RelationalDBIntegration) -> None:
Expand Down Expand Up @@ -212,15 +210,13 @@ def setup_data_integrations(client: Client, filter_to: Optional[str] = None) ->
for integration_name in data_integrations:
# Only connect to integrations that don't already exist.
if integration_name not in connected_integrations.keys():
print("Fetching integration credentials ...")
integration_config = _fetch_integration_credentials("data", integration_name)

# Stand up the external integration first.
if integration_config["type"] == ServiceType.SQLITE:
_setup_external_sqlite_db(integration_config["database"])

if integration_config["type"] == ServiceType.POSTGRES:
print("Postgres case hit!!")
_setup_postgres_db()

client.connect_integration(
Expand Down

0 comments on commit 212c789

Please sign in to comment.