fix(fuselage)!: Bundling size - #1754
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2ff8cf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tassoevan
force-pushed
the
fix/fuselage-build
branch
from
September 5, 2025 20:01
b6c4578 to
a67fd92
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the bundle size of @rocket.chat/fuselage by externalizing dependencies and modernizing the build configuration.
- Replaced hardcoded external dependencies with dynamic externalization of all package dependencies
- Updated TypeScript compilation target from ES5 to ES2024 and removed ES5 compatibility checks
- Converted import statements to use TypeScript's
typekeyword for type-only imports
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/fuselage/webpack.config.js | Dynamically externalizes all dependencies and removes hardcoded externals list |
| packages/fuselage/tsconfig.json | Updates TypeScript target to ES2024 and adds modern module resolution settings |
| packages/fuselage/package.json | Removes ES5 compatibility checks and simplifies build scripts |
| packages/fuselage/src/**/*.ts(x) | Converts imports to type-only imports using type keyword |
| package.json | Updates Node.js and Yarn versions |
| .yarnrc.yml | Updates Yarn version to 4.9.4 |
| .github/workflows/*.yml | Updates CI/CD workflows to use newer Node.js version |
| .changeset/sour-monkeys-change.md | Adds changeset documentation for the bundle size improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tassoevan
added
📦 fuselage
minor
tassoevan
marked this pull request as ready for review
September 5, 2025 20:16
tassoevan
force-pushed
the
fix/fuselage-build
branch
from
September 11, 2025 06:10
2b7040c to
596ac2a
Compare
dougfabris
reviewed
Sep 17, 2025
tassoevan
force-pushed
the
fix/fuselage-build
branch
from
September 18, 2025 01:09
d7ebc6f to
e4a677a
Compare
Member
|
I think this is more a feat than a fix |
dougfabris
approved these changes
Sep 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It reduces the bundle size of
@rocket.chat/fuselageby externalizing more dependencies and increasing the ECMAScript version.Issue(s)
Further comments