chore!: remove Atlassian Crowd integration - #41986
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 5a20f70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (78)
💤 Files with no reviewable changes (72)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used📓 Path-based instructions (2)The main Rocket.Chat Meteor application resides in `apps/meteor/`; place its application code there rather than in other monorepo areas.📄 CodeRabbit inference engine (CLAUDE.md) Files:
Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc) Files:
🪛 LanguageTooldocs/backend-folder-structure.md[uncategorized] ~71-~71: The official name of this software platform is spelled with a capital “H”. (GITHUB) [uncategorized] ~71-~71: The official name of this content management system is spelled with a capital “P”. (WORDPRESS) 🔇 Additional comments (6)
WalkthroughAtlassian Crowd authentication, synchronization, settings, model APIs, dependency wiring, and translations were removed. Migration v342 deletes related settings and scheduled jobs. The changeset documents major version updates and retained user accounts. ChangesAtlassian Crowd removal
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to This breaking change removes Crowd authentication and deletes its stored settings and scheduled synchronization during upgrade. It is mergeable with explicit owner awareness that overlapping old and new application instances could temporarily operate against state being removed, so rollout sequencing should be confirmed. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Atlassian is winding Crowd down and the LDAP integration covers directory-backed authentication (Crowd itself exposes an LDAP interface). Removes the CROWD_* settings and admin section, the crowd login handler, the crowd_test_connection/crowd_sync_users methods, the background user-sync cron job, the atlassian-crowd-patched dependency and related i18n strings. A migration deletes the stored settings and any scheduled CROWD_Sync job on upgrade; users provisioned through Crowd keep their accounts.
KevLehman
force-pushed
the
chore/remove-atlassian-crowd
branch
from
August 28, 2026 15:09
05d4497 to
5a20f70
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-9.0.0 #41986 +/- ##
=================================================
+ Coverage 69.64% 69.74% +0.10%
=================================================
Files 4253 4250 -3
Lines 169240 169013 -227
Branches 30139 30129 -10
=================================================
+ Hits 117873 117885 +12
+ Misses 46186 45967 -219
+ Partials 5181 5161 -20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 79 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
julio-rocketchat
approved these changes
Aug 28, 2026
ricardogarim
approved these changes
Aug 31, 2026
dougfabris
approved these changes
Aug 31, 2026
tassoevan
approved these changes
Aug 31, 2026
tassoevan
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removes the first-party Atlassian Crowd integration from core, targeting 9.0.0 (breaking). Atlassian has announced Crowd's end-of-life (Server support ended Feb 2024; Data Center: no new licences from 30 Mar 2026, read-only on 28 Mar 2029), usage is marginal, and the LDAP integration covers the same need — Crowd itself exposes an LDAP interface.
What is removed:
AtlassianCrowdgroup and allCROWD_*settings (server/settings/crowd.ts), including the Test Connection / Sync Users action settings. The Admin → Settings → Atlassian Crowd section disappears with them; theadmin/settings/AtlassianCrowddeep link falls into the settings page's existing not-found handling.Accounts.registerLoginHandler('crowd')and the clientMeteor.loginWithCrowdwiring. A login request withcrowd: trueis now rejected by Meteor's accounts system with a handled "Unrecognized options for login request" 400 error.crowd_test_connectionandcrowd_sync_users.CROWD_Synccron job and its settings watcher.atlassian-crowd-patchedand its ambient type declaration.Users.findCrowdUsers(only consumer was the sync job).AuthenticationProviderlogin-method selection and the LDAP/Crowd collision warning hook.Clean_Usernames,Sync_Users,Sync_Intervalandevery_10_minuteskeys across all locales.Migration
v342deletes the storedCROWD_*/AtlassianCrowdsettings and any scheduledCROWD_Syncjob document fromrocketchat_cron, so upgraded workspaces have no orphaned admin entries or scheduled jobs.Crowd-provisioned users keep their accounts, profile data, roles and room memberships (
crowd/crowd_usernamefields are left on user documents as inert data). They must sign in through another method: LDAP (pointed at Crowd or the directory behind it), or local password via the "Forgot password" flow. Workspaces where Crowd was the only auth path should follow the upgrade guide's recovery route (existing local admin credentials / password reset / re-provisioning via LDAP) — docs update tracked with the release notes.Issue(s)
Steps to test or reproduce
CROWD_Enable, sync on) soCROWD_*settings and aCROWD_Syncjob exist.admin/settings/AtlassianCrowdresolves to not-found,db.rocketchat_settings.find({_id: /^CROWD_/})anddb.rocketchat_cron.find({name: 'CROWD_Sync'})are empty.crowd: truelogin request — clean 400 error, no 500/hang.Further comments
https://rocketchat.atlassian.net/browse/CORE-2647
Summary by CodeRabbit
Breaking Changes
Bug Fixes
Documentation