Skip to content

chore: remove stale modules - #41918

Merged
tassoevan merged 1 commit into
refactor/move-app-emoji-client-modulesfrom
refactor/remove-stale-modules
Aug 26, 2026
Merged

chore: remove stale modules#41918
tassoevan merged 1 commit into
refactor/move-app-emoji-client-modulesfrom
refactor/remove-stale-modules

Conversation

@tassoevan

@tassoevan tassoevan commented Aug 24, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

It deletes stale modules.

Issue(s)

Steps to test or reproduce

Further comments


Stack created with GitHub Stacks CLIGive Feedback 💬

Review in cubic

Summary by CodeRabbit

  • Style
    • Removed custom GitLab and WordPress login button imagery.
    • Login buttons now use the default or inherited styling.

Task: ARCH-2389

@tassoevan
tassoevan requested a review from a team as a code owner August 24, 2026 20:49
@dionisio-bot

dionisio-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6b0085e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eae458d4-27bf-466f-863e-a17a1f5715ea

📥 Commits

Reviewing files that changed from the base of the PR and between 5309bd1 and fd5f5e9.

📒 Files selected for processing (5)
  • apps/meteor/app/gitlab/client/gitlab-login-button.css
  • apps/meteor/app/gitlab/client/index.ts
  • apps/meteor/app/wordpress/client/index.ts
  • apps/meteor/app/wordpress/client/wordpress-login-button.css
  • apps/meteor/client/importPackages.ts
💤 Files with no reviewable changes (5)
  • apps/meteor/app/wordpress/client/wordpress-login-button.css
  • apps/meteor/app/wordpress/client/index.ts
  • apps/meteor/app/gitlab/client/gitlab-login-button.css
  • apps/meteor/client/importPackages.ts
  • apps/meteor/app/gitlab/client/index.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build

Walkthrough

The change removes GitLab and WordPress login button stylesheet imports and deletes their embedded background image rules.

Changes

Login button styling cleanup

Layer / File(s) Summary
Remove login button stylesheet loading
apps/meteor/app/gitlab/client/index.ts, apps/meteor/app/gitlab/client/gitlab-login-button.css, apps/meteor/app/wordpress/client/index.ts, apps/meteor/app/wordpress/client/wordpress-login-button.css, apps/meteor/client/importPackages.ts
GitLab and WordPress client imports, custom login button CSS rules, and integration imports were removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to fd5f5

This change removes stale client modules and their imports without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of stale GitLab and WordPress modules and stylesheets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tassoevan tassoevan added this to the 8.9.0 milestone Aug 24, 2026
@tassoevan

Copy link
Copy Markdown
Member Author

/jira ARCH

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.30%. Comparing base (8d174a8) to head (6b0085e).

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                             @@
##           refactor/move-app-emoji-client-modules   #41918      +/-   ##
==========================================================================
- Coverage                                   69.32%   69.30%   -0.03%     
==========================================================================
  Files                                        4261     4254       -7     
  Lines                                      168843   168649     -194     
  Branches                                    30122    30041      -81     
==========================================================================
- Hits                                       117044   116875     -169     
+ Misses                                      46604    46596       -8     
+ Partials                                     5195     5178      -17     
Flag Coverage Δ
e2e 58.81% <ø> (-0.07%) ⬇️
e2e-api 45.90% <ø> (-0.24%) ⬇️
unit 71.20% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan
tassoevan force-pushed the refactor/remove-stale-modules branch 2 times, most recently from 3521067 to e9fca37 Compare August 25, 2026 03:26
@tassoevan
tassoevan force-pushed the refactor/remove-stale-modules branch from e9fca37 to 145c840 Compare August 25, 2026 03:57
@tassoevan
tassoevan force-pushed the refactor/remove-stale-modules branch from 145c840 to a53a436 Compare August 25, 2026 04:27
@tassoevan
tassoevan force-pushed the refactor/remove-stale-modules branch from a53a436 to 6b0085e Compare August 25, 2026 14:45
@tassoevan
tassoevan added this pull request to the merge queue Aug 26, 2026
Merged via the queue into develop with commit 13cf7ad Aug 26, 2026
99 of 101 checks passed
@tassoevan
tassoevan deleted the refactor/remove-stale-modules branch August 26, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants