chore!: remove FileUpload_S3_SignatureVersion setting

[KevLehman]

Proposed changes (including videos or screenshots)

Adds migration v337 that deletes the leftover FileUpload_S3_SignatureVersion setting document from the database.

The setting itself was already removed from the settings definitions, the S3 store config, and all translations in #39244; this migration only clears the stale document that existing installations still carry.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1934

Steps to test or reproduce

1. On a pre-9.0 database, confirm db.rocketchat_settings.findOne({ _id: 'FileUpload_S3_SignatureVersion' }) returns a document.
2. Start the server on this branch and let migrations run.
3. Confirm the document is gone and rocketchat_migrations reports version 337.

Further comments

No changeset: the setting has been unused since #39244, so there is no user-visible behavior change.

Summary by CodeRabbit

• Bug Fixes
  • Removed the obsolete S3 signature version setting during application startup migration.
  • Improved upgrade compatibility for existing installations using legacy configuration.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 466b34d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Changeset mismatch

The PR title indicates a breaking change (!), but no changeset declares a major bump — at least one is required.

Please align the PR title, milestone and changesets.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a4bd409d-df93-44b5-bf29-97c6e692f14f

📥 Commits

Reviewing files that changed from the base of the PR and between e7cd9a3 and 466b34d.

📒 Files selected for processing (2)

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (7)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Hacktron Security Check
• GitHub Check: 🔨 Test Storybook / Test Storybook
• GitHub Check: 🔎 Code Check / TypeScript
• GitHub Check: 🔎 Code Check / Code Lint
• GitHub Check: 🔨 Test Unit / Unit Tests
• GitHub Check: 📦 Meteor Build (coverage)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

apps/meteor/**

📄 CodeRabbit inference engine (CLAUDE.md)

The main Rocket.Chat Meteor application resides in apps/meteor/; place its application code there rather than in other monorepo areas.

Files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

🧠 Learnings (4)

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

📚 Learning: 2026-08-05T22:02:59.828Z

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 41707
File: apps/meteor/server/hooks/messages/processThreads.ts:66-68
Timestamp: 2026-08-05T22:02:59.828Z
Learning: In Rocket.Chat Meteor server code, `callbacks.runAsync` returns its input item rather than the asynchronous callback promise. Callers of `afterReadMessages` must invoke `callbacks.runAsync` without awaiting it, keeping read-receipt I/O off the message-send path; this includes `apps/meteor/server/hooks/messages/processThreads.ts`.

Applied to files:

• apps/meteor/server/startup/migrations/index.ts
• apps/meteor/server/startup/migrations/v337.ts

🔇 Additional comments (2)

apps/meteor/server/startup/migrations/index.ts (1)

45-45: LGTM!

apps/meteor/server/startup/migrations/v337.ts (1)

1-1: LGTM!

Also applies to: 3-3, 5-11

---

Walkthrough

Migration v337 is added to the startup migration sequence. Its up operation deletes the FileUpload_S3_SignatureVersion setting.

Changes

S3 setting migration

Layer / File(s)	Summary
Register and execute migration v337 apps/meteor/server/startup/migrations/index.ts, apps/meteor/server/startup/migrations/v337.ts	The migration index imports v337. Migration v337 deletes FileUpload_S3_SignatureVersion during its up operation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 466b3

This PR only removes an unused stale database setting through a localized migration, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removal of the FileUpload_S3_SignatureVersion setting, which is the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• CORE-1934: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 2 files

_{Re-trigger cubic}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.83%. Comparing base (e7cd9a3) to head (466b34d).
⚠️ Report is 1 commits behind head on release-9.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-9.0.0   #41809      +/-   ##
=================================================
- Coverage          69.16%   68.83%   -0.34%     
=================================================
  Files               4186     4134      -52     
  Lines             165146   158163    -6983     
  Branches           29370    28067    -1303     
=================================================
- Hits              114224   108864    -5360     
+ Misses             45790    44149    -1641     
- Partials            5132     5150      +18     

Flag	Coverage Δ
e2e	59.20% <ø> (-0.01%)	⬇️
e2e-api	46.00% <50.00%> (-0.04%)	⬇️
unit	70.53% <ø> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.