fix: thread pagination not loading when dragging the scrollbar - #41705
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Walkthrough
ChangesThread pagination interaction
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41705 +/- ##
=========================================
Coverage 68.64% 68.64%
=========================================
Files 4164 4164
Lines 158957 159264 +307
Branches 28160 28282 +122
=========================================
+ Hits 109113 109334 +221
- Misses 44678 44771 +93
+ Partials 5166 5159 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
we should add a |
Proposed changes (including videos or screenshots)
Thread pagination was guarded until the user interacted with the message list. However, dragging the custom overlay scrollbar did not count as an interaction because the scrollbar is rendered outside the scrollable viewport.
This change listens for
pointerdownon the viewport's parent, where events from the overlay scrollbar are received. The listener is removed during cleanup. This matches the existing room-history pagination behavior in #41098.The test verifies that:
Issue(s)
CORE-2512
Steps to test or reproduce
Further comments
Summary by CodeRabbit