regression: skin-toned emoji not enlarged when sent alone

[ricardogarim]

Proposed changes (including videos or screenshots)

Skin-toned emoji variants (e.g. high_five ✋🏽) stayed small when sent as an emoji-only message, while the default version (✋) was correctly enlarged.

Root cause: A message made only of emoji is enlarged only when it is recognized as a single emoji. A skin-toned emoji is actually two parts — a base emoji plus a separate skin-tone modifier — that must be joined into one.

Emoji are spread across several Unicode ranges, and the message parser only joined the skin-tone modifier for some of them. For two of those ranges (which include hands like ✋ ✌ ✍ ☝ ⛹), the modifier was not joined, so a skin-toned emoji was read as two things: the base emoji plus a leftover skin-tone swatch. The result was a big default-colored hand next to a tiny swatch, instead of one enlarged skin-toned emoji. The plain version (✋) worked because it has no modifier to lose.

Fix: Allow those two ranges to join the skin-tone modifier too, like the others already did. Now a skin-toned emoji is read as a single emoji and enlarges correctly. Emoji without a skin tone are unaffected.

Issue(s)

• CORE-2456
• introduced by chore: remove emojione in favor of native emojis #39411

Steps to test or reproduce

1. Send high_five (✋) alone → enlarged.
2. Pick a skin tone and send high_five with different tone (✋🏽) alone.
3. Before: stays small. After: enlarged with the correct skin tone.

Further comments

Summary by CodeRabbit

• Bug Fixes

  • Improved recognition of additional Unicode emojis with skin-tone modifiers.
  • Correctly parses combined emoji sequences and emojis embedded within surrounding text.

• Tests

  • Added coverage for hand, arm, and activity emojis, including modified and concatenated forms.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: bacca02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a4499f8-f31d-43ae-9b54-dcda011cbe1b

📥 Commits

Reviewing files that changed from the base of the PR and between e106db1 and bacca02.

📒 Files selected for processing (2)

• packages/message-parser/src/grammar.pegjs
• packages/message-parser/tests/emoji.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/message-parser/src/grammar.pegjs
• packages/message-parser/tests/emoji.test.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout. (4)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: Hacktron Security Check
• GitHub Check: CodeQL-Build

---

Walkthrough

The message parser now applies Fitzpatrick modifiers to additional Unicode emoji categories. Tests cover standalone, concatenated, and inline skin-toned emoji parsing.

Changes

Unicode emoji parsing

Layer / File(s)	Summary
Apply skin-tone modifiers across emoji categories packages/message-parser/src/grammar.pegjs, packages/message-parser/tests/emoji.test.ts	The grammar includes dingbat and miscellaneous symbol emoji in the modifier-capable group, with tests for standalone, concatenated, and inline variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• RocketChat/Rocket.Chat#41441: Updates the same emoji grammar rule and related multi-code-point emoji tests.

Suggested labels: type: bug

Suggested reviewers: cardoso

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the fix for single skin-toned emoji being parsed incorrectly and not enlarged.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• CORE-2456: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 3 files

_{Re-trigger cubic}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.60%. Comparing base (8d4507d) to head (bacca02).
⚠️ Report is 8 commits behind head on release-8.7.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.7.0   #41515      +/-   ##
=================================================
+ Coverage          68.58%   68.60%   +0.01%     
=================================================
  Files               4134     4135       +1     
  Lines             160802   160814      +12     
  Branches           29244    29236       -8     
=================================================
+ Hits              110294   110332      +38     
+ Misses             45403    45364      -39     
- Partials            5105     5118      +13     

Flag	Coverage Δ
e2e	58.86% <ø> (-0.02%)	⬇️
e2e-api	45.62% <ø> (+0.29%)	⬆️
unit	70.54% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.