chore: correct Phishing-Resistant MFA changeset to minor bump - #41492
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
| Name | Type |
|---|---|
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/model-typings | Minor |
| @rocket.chat/core-typings | Minor |
| @rocket.chat/rest-typings | Minor |
| @rocket.chat/passport-x | Minor |
| @rocket.chat/desktop-api | Minor |
| @rocket.chat/models | Minor |
| @rocket.chat/i18n | Minor |
| @rocket.chat/meteor | Minor |
| @rocket.chat/ui-client | Major |
| @rocket.chat/mock-providers | Patch |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/livechat | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/ui-voip | Major |
| @rocket.chat/ui-composer | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-03-16T21:50:37.589ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe PR updates package changeset bump classifications from major to minor and removes another changeset describing the phishing-resistant multi-factor authentication feature set. ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes (including videos or screenshots)
Fixes the changesets from "feat: Phishing resistant MFA" (#40721):
major. Since amajoron@rocket.chat/meteor(8.7.0-develop) would force the release to9.0.0, this lowers them tominor— the change is additive/non-breaking and opt-in behindAccounts_OAuth_Use_Modern_Flow, so it stays on the 8.7 line.breezy-parts-kissandflat-poets-cheat), one with major and other as minor, which would list it twice in the release notes. Consolidated into a single changeset covering all 9 packages.Issue(s)
Follow-up to #40721.
Steps to test or reproduce
yarn changeset status --verbose→ affected packages resolve to a minor bump (@rocket.chat/meteor→8.7.0), none to a new major, and the feature appears once.Further comments
Metadata-only change; no code or runtime behavior affected.
Summary by CodeRabbit