Skip to content

chore: correct Phishing-Resistant MFA changeset to minor bump - #41492

Merged
ggazzo merged 1 commit into
developfrom
chore/mfa-changeset-minor-bump
Jul 21, 2026
Merged

chore: correct Phishing-Resistant MFA changeset to minor bump#41492
ggazzo merged 1 commit into
developfrom
chore/mfa-changeset-minor-bump

Conversation

@ricardogarim

@ricardogarim ricardogarim commented Jul 20, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Fixes the changesets from "feat: Phishing resistant MFA" (#40721):

  • That PR marked the packages as major. Since a major on @rocket.chat/meteor (8.7.0-develop) would force the release to 9.0.0, this lowers them to minor — the change is additive/non-breaking and opt-in behind Accounts_OAuth_Use_Modern_Flow, so it stays on the 8.7 line.
  • That PR also shipped two changesets describing the same feature (breezy-parts-kiss and flat-poets-cheat), one with major and other as minor, which would list it twice in the release notes. Consolidated into a single changeset covering all 9 packages.

Issue(s)

Follow-up to #40721.

Steps to test or reproduce

yarn changeset status --verbose → affected packages resolve to a minor bump (@rocket.chat/meteor8.7.0), none to a new major, and the feature appears once.

Further comments

Metadata-only change; no code or runtime behavior affected.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated release classification for several packages from major to minor.
    • Removed a duplicate release entry related to phishing-resistant multi-factor authentication.
    • No user-facing functionality or behavior changes are included in this update.

@dionisio-bot

dionisio-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0e81c0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 20 packages
Name Type
@rocket.chat/web-ui-registration Major
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/passport-x Minor
@rocket.chat/desktop-api Minor
@rocket.chat/models Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/ui-client Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/ui-composer Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eaf9a67f-3998-4a8c-b413-09955b476e03

📥 Commits

Reviewing files that changed from the base of the PR and between 4a4c297 and 0e81c0d.

📒 Files selected for processing (2)
  • .changeset/breezy-parts-kiss.md
  • .changeset/flat-poets-cheat.md
💤 Files with no reviewable changes (1)
  • .changeset/flat-poets-cheat.md
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-03-16T21:50:37.589Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:37.589Z
Learning: For changes related to OpenAPI migrations in Rocket.Chat/OpenAPI, when removing endpoint types and validators from rocket.chat/rest-typings (e.g., UserRegisterParamsPOST, /v1/users.register) document this as a minor changeset (not breaking) per RocketChat/Rocket.Chat-Open-API#150 Rule 7. Note that the endpoint type is re-exposed via a module augmentation .d.ts in the consuming package (e.g., packages/web-ui-registration/src/users-register.d.ts). In reviews, ensure the changeset clearly states: this is a non-breaking change, the major version should not be bumped, and the changeset reflects a minor version bump. Do not treat this as a breaking change during OpenAPI migrations.

Applied to files:

  • .changeset/breezy-parts-kiss.md
🔇 Additional comments (1)
.changeset/breezy-parts-kiss.md (1)

2-10: LGTM!


Walkthrough

The PR updates package changeset bump classifications from major to minor and removes another changeset describing the phishing-resistant multi-factor authentication feature set.

Changes

Release metadata

Layer / File(s) Summary
Package bump classifications
.changeset/breezy-parts-kiss.md, .changeset/flat-poets-cheat.md
Listed @rocket.chat/* package bumps change from major to minor, and the superseded changeset is removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: type: chore

Suggested reviewers: ggazzo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: correcting the Phishing-Resistant MFA changeset to a minor bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ricardogarim
ricardogarim marked this pull request as ready for review July 20, 2026 23:04
@ricardogarim ricardogarim added this to the 8.7.0 milestone Jul 20, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@tassoevan
tassoevan enabled auto-merge July 20, 2026 23:09
@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Jul 21, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 21, 2026
@ggazzo
ggazzo disabled auto-merge July 21, 2026 00:37
@ggazzo
ggazzo merged commit 6a8b36b into develop Jul 21, 2026
9 checks passed
@ggazzo
ggazzo deleted the chore/mfa-changeset-minor-bump branch July 21, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants