fix: Deleted thread not being displayed correctly in thread context - #41484
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: eaeab92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughDeleted thread messages now use localized message-type text when they lack content. Thread normalization and title rendering receive i18n translators, while existing markdown and attachment handling remains in place. Locale keys and tests are updated accordingly. ChangesLocalized thread message rendering
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
from
July 20, 2026 21:28
0924fda to
d4c3eb4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41484 +/- ##
===========================================
+ Coverage 68.60% 68.65% +0.04%
===========================================
Files 4134 4135 +1
Lines 160803 160585 -218
Branches 29246 29299 +53
===========================================
- Hits 110323 110253 -70
+ Misses 45375 45223 -152
- Partials 5105 5109 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
2 times, most recently
from
July 21, 2026 15:53
1beceb7 to
f03567f
Compare
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
from
July 21, 2026 17:00
f03567f to
2a1b6ca
Compare
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
from
July 21, 2026 17:34
2a1b6ca to
78307c7
Compare
dougfabris
marked this pull request as ready for review
July 21, 2026 19:56
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/sparkly-regions-drive.md:
- Line 6: Update the changeset description to use the corrected wording: “Fixes
an issue where deleted thread messages are displayed as empty in the thread
context.”
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 496139ea-27d1-40d0-9238-0ac6c0dc1dd2
📒 Files selected for processing (9)
.changeset/sparkly-regions-drive.mdapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxapps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListRow.tsxapps/meteor/client/views/room/contextualBar/Threads/components/ThreadListItem.tsxapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.tspackages/message-types/src/MessageTypes.tspackages/message-types/src/registrations/common.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: Hacktron Security Check
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListRow.tsxpackages/message-types/src/registrations/common.tsapps/meteor/client/views/room/contextualBar/Threads/components/ThreadListItem.tsxapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.tsapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxpackages/message-types/src/MessageTypes.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.ts
🧠 Learnings (9)
📚 Learning: 2026-03-16T21:50:37.589Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:37.589Z
Learning: For changes related to OpenAPI migrations in Rocket.Chat/OpenAPI, when removing endpoint types and validators from rocket.chat/rest-typings (e.g., UserRegisterParamsPOST, /v1/users.register) document this as a minor changeset (not breaking) per RocketChat/Rocket.Chat-Open-API#150 Rule 7. Note that the endpoint type is re-exposed via a module augmentation .d.ts in the consuming package (e.g., packages/web-ui-registration/src/users-register.d.ts). In reviews, ensure the changeset clearly states: this is a non-breaking change, the major version should not be bumped, and the changeset reflects a minor version bump. Do not treat this as a breaking change during OpenAPI migrations.
Applied to files:
.changeset/sparkly-regions-drive.md
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.ts
📚 Learning: 2026-05-11T20:30:35.265Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 40480
File: apps/meteor/client/meteor/startup/accounts.ts:59-61
Timestamp: 2026-05-11T20:30:35.265Z
Learning: In Rocket.Chat’s Meteor client code, when calling `dispatchToastMessage` with `{ type: 'error' }`, pass the raw caught error object as `message` without manual normalization. `dispatchToastMessage` is designed to accept `message: unknown` for error toasts, so avoid converting errors to strings (e.g., `String(error)`) or extracting `error.message` before passing them.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.ts
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tspackages/message-types/src/registrations/common.tsapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.tspackages/message-types/src/MessageTypes.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tspackages/message-types/src/registrations/common.tsapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.tspackages/message-types/src/MessageTypes.ts
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/lib/normalizeThreadMessage.spec.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.tsapps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListRow.tsxpackages/message-types/src/registrations/common.tsapps/meteor/client/views/room/contextualBar/Threads/components/ThreadListItem.tsxapps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.tsapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxpackages/message-types/src/MessageTypes.ts
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListRow.tsxapps/meteor/client/views/room/contextualBar/Threads/components/ThreadListItem.tsxapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/lib/normalizeThreadMessage.tsx
🔇 Additional comments (9)
.changeset/sparkly-regions-drive.md (1)
1-4: LGTM!packages/message-types/src/MessageTypes.ts (1)
7-7: LGTM!packages/message-types/src/registrations/common.ts (1)
115-115: LGTM!apps/meteor/client/lib/normalizeThreadMessage.tsx (1)
1-6: LGTM!Also applies to: 26-28, 57-60
apps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListRow.tsx (1)
4-4: LGTM!Also applies to: 17-20
apps/meteor/client/views/room/contextualBar/Threads/components/ThreadListItem.tsx (1)
7-7: LGTM!Also applies to: 22-25
apps/meteor/client/lib/normalizeThreadMessage.spec.tsx (1)
1-4: LGTM!Also applies to: 19-20, 33-34, 43-44, 56-70, 81-104
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.ts (1)
1-20: LGTM!Also applies to: 51-56
apps/meteor/client/views/room/contextualBar/Threads/hooks/useNormalizedThreadTitleHtml.spec.ts (1)
1-72: LGTM!
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
tassoevan
previously approved these changes
Jul 21, 2026
![hacktron-app[bot]](https://avatars.githubusercontent.com/in/1250513?s=60&v=4){kind=small}
tassoevan
previously approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 59 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
from
July 22, 2026 15:03
3c5099b to
246a281
Compare
tassoevan
previously approved these changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/i18n/src/locales/be-BY.i18n.json`:
- Line 1479: Update the message_removed locale entry to use the consistent
Belarusian wording “паведамленне выдалена”, matching the existing
Message_removed entry.
In `@packages/i18n/src/locales/de.i18n.json`:
- Line 2753: Update the message_removed translation value to capitalize the
German noun, using “Nachricht entfernt” while preserving the existing key and
lowercase wording structure.
In `@packages/i18n/src/locales/fi.i18n.json`:
- Around line 2819-2820: Update the Finnish locale entries so Message_removed
returns the capitalized translation "Viesti poistettu", while message_removed
remains "viesti poistettu".
In `@packages/i18n/src/locales/it.i18n.json`:
- Around line 1848-1849: Update the Message_removed translation to sentence case
while preserving the lowercase message_removed translation in
packages/i18n/src/locales/it.i18n.json lines 1848-1849. Apply the same
distinction in packages/i18n/src/locales/gl.i18n.json line 183 by making
Message_removed sentence-cased and retaining the lowercase value.
In `@packages/i18n/src/locales/uk.i18n.json`:
- Around line 1892-1893: Update the Message_removed translation value to begin
with an uppercase Ukrainian character, while leaving the lowercase
message_removed variant unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ea03022a-5ba7-499e-aa1e-90edac951f39
📒 Files selected for processing (59)
packages/i18n/src/locales/af.i18n.jsonpackages/i18n/src/locales/ar.i18n.jsonpackages/i18n/src/locales/az.i18n.jsonpackages/i18n/src/locales/be-BY.i18n.jsonpackages/i18n/src/locales/bg.i18n.jsonpackages/i18n/src/locales/bs.i18n.jsonpackages/i18n/src/locales/ca.i18n.jsonpackages/i18n/src/locales/cs.i18n.jsonpackages/i18n/src/locales/cy.i18n.jsonpackages/i18n/src/locales/da.i18n.jsonpackages/i18n/src/locales/de-AT.i18n.jsonpackages/i18n/src/locales/de.i18n.jsonpackages/i18n/src/locales/el.i18n.jsonpackages/i18n/src/locales/en.i18n.jsonpackages/i18n/src/locales/eo.i18n.jsonpackages/i18n/src/locales/es.i18n.jsonpackages/i18n/src/locales/fa.i18n.jsonpackages/i18n/src/locales/fi.i18n.jsonpackages/i18n/src/locales/fr.i18n.jsonpackages/i18n/src/locales/gl.i18n.jsonpackages/i18n/src/locales/he.i18n.jsonpackages/i18n/src/locales/hi-IN.i18n.jsonpackages/i18n/src/locales/hr.i18n.jsonpackages/i18n/src/locales/hu.i18n.jsonpackages/i18n/src/locales/id.i18n.jsonpackages/i18n/src/locales/it.i18n.jsonpackages/i18n/src/locales/ja.i18n.jsonpackages/i18n/src/locales/ka-GE.i18n.jsonpackages/i18n/src/locales/km.i18n.jsonpackages/i18n/src/locales/ko.i18n.jsonpackages/i18n/src/locales/ku.i18n.jsonpackages/i18n/src/locales/lo.i18n.jsonpackages/i18n/src/locales/lt.i18n.jsonpackages/i18n/src/locales/lv.i18n.jsonpackages/i18n/src/locales/mn.i18n.jsonpackages/i18n/src/locales/ms-MY.i18n.jsonpackages/i18n/src/locales/nb.i18n.jsonpackages/i18n/src/locales/nl.i18n.jsonpackages/i18n/src/locales/nn.i18n.jsonpackages/i18n/src/locales/pl.i18n.jsonpackages/i18n/src/locales/pt-BR.i18n.jsonpackages/i18n/src/locales/pt.i18n.jsonpackages/i18n/src/locales/ro.i18n.jsonpackages/i18n/src/locales/ru.i18n.jsonpackages/i18n/src/locales/sk-SK.i18n.jsonpackages/i18n/src/locales/sl-SI.i18n.jsonpackages/i18n/src/locales/sq.i18n.jsonpackages/i18n/src/locales/sr.i18n.jsonpackages/i18n/src/locales/sv.i18n.jsonpackages/i18n/src/locales/ta-IN.i18n.jsonpackages/i18n/src/locales/th-TH.i18n.jsonpackages/i18n/src/locales/tr.i18n.jsonpackages/i18n/src/locales/ug.i18n.jsonpackages/i18n/src/locales/uk.i18n.jsonpackages/i18n/src/locales/vi-VN.i18n.jsonpackages/i18n/src/locales/zh-HK.i18n.jsonpackages/i18n/src/locales/zh-TW.i18n.jsonpackages/i18n/src/locales/zh.i18n.jsonpackages/message-types/src/registrations/common.ts
🚧 Files skipped from review as they are similar to previous changes (38)
- packages/i18n/src/locales/bs.i18n.json
- packages/i18n/src/locales/da.i18n.json
- packages/i18n/src/locales/af.i18n.json
- packages/i18n/src/locales/ug.i18n.json
- packages/i18n/src/locales/lv.i18n.json
- packages/i18n/src/locales/fr.i18n.json
- packages/i18n/src/locales/sr.i18n.json
- packages/i18n/src/locales/pt.i18n.json
- packages/i18n/src/locales/cy.i18n.json
- packages/i18n/src/locales/sv.i18n.json
- packages/i18n/src/locales/nl.i18n.json
- packages/i18n/src/locales/hi-IN.i18n.json
- packages/i18n/src/locales/zh-HK.i18n.json
- packages/i18n/src/locales/sq.i18n.json
- packages/i18n/src/locales/bg.i18n.json
- packages/i18n/src/locales/he.i18n.json
- packages/i18n/src/locales/lt.i18n.json
- packages/i18n/src/locales/pl.i18n.json
- packages/i18n/src/locales/hu.i18n.json
- packages/i18n/src/locales/ru.i18n.json
- packages/i18n/src/locales/ar.i18n.json
- packages/i18n/src/locales/sk-SK.i18n.json
- packages/i18n/src/locales/es.i18n.json
- packages/i18n/src/locales/pt-BR.i18n.json
- packages/i18n/src/locales/ta-IN.i18n.json
- packages/i18n/src/locales/zh.i18n.json
- packages/i18n/src/locales/el.i18n.json
- packages/i18n/src/locales/ca.i18n.json
- packages/i18n/src/locales/ja.i18n.json
- packages/message-types/src/registrations/common.ts
- packages/i18n/src/locales/mn.i18n.json
- packages/i18n/src/locales/lo.i18n.json
- packages/i18n/src/locales/th-TH.i18n.json
- packages/i18n/src/locales/nb.i18n.json
- packages/i18n/src/locales/fa.i18n.json
- packages/i18n/src/locales/zh-TW.i18n.json
- packages/i18n/src/locales/cs.i18n.json
- packages/i18n/src/locales/ku.i18n.json
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
⚠️ CI failures not shown inline (3)
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
🔇 Additional comments (13)
packages/i18n/src/locales/az.i18n.json (1)
1459-1459: LGTM!packages/i18n/src/locales/de-AT.i18n.json (1)
1460-1460: LGTM!packages/i18n/src/locales/ms-MY.i18n.json (1)
1461-1461: LGTM!packages/i18n/src/locales/nn.i18n.json (1)
3263-3266: LGTM!packages/i18n/src/locales/ro.i18n.json (1)
1457-1459: LGTM!packages/i18n/src/locales/sl-SI.i18n.json (1)
1454-1454: LGTM!packages/i18n/src/locales/tr.i18n.json (1)
1744-1744: LGTM!packages/i18n/src/locales/vi-VN.i18n.json (1)
1549-1549: LGTM!packages/i18n/src/locales/en.i18n.json (1)
3714-3715: LGTM!packages/i18n/src/locales/eo.i18n.json (1)
1457-1457: LGTM!packages/i18n/src/locales/ka-GE.i18n.json (1)
1982-1984: LGTM!packages/i18n/src/locales/km.i18n.json (1)
1722-1724: LGTM!packages/i18n/src/locales/ko.i18n.json (1)
2156-2156: LGTM!
jessicaschelly
added
the
stat: QA assured
dougfabris
force-pushed
the
fix/normalize-removed-thread
branch
from
July 22, 2026 15:35
246a281 to
65bd1bf
Compare
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
tassoevan
approved these changes
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
dougfabris
added
stat: QA assured
Draft
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-2414
Summary by CodeRabbit