fix: Restore Away to quick status menu - #41414
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b14f55a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
|
| Layer / File(s) | Summary |
|---|---|
Restore Away in status menus apps/meteor/client/components/UserStatusMenu.tsx, apps/meteor/client/navbar/NavBarSettingsToolbar/UserMenu/hooks/useStatusItems.tsx, .changeset/ready-taxis-join.md |
Status option builders always include “Away,” while the changeset documents the restored preset and patch release. |
Preserve Away initial status apps/meteor/client/lib/getUserInitialStatus.ts |
Initial status now uses the user’s current status directly, defaulting to Online when no status is present. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested labels: type: bug
Suggested reviewers: dougfabris
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title matches the main change by restoring Away as a selectable status, though it only mentions the quick status menu. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- CORE-2430: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41414 +/- ##
===========================================
- Coverage 68.48% 68.42% -0.06%
===========================================
Files 4092 4092
Lines 158216 158276 +60
Branches 28678 28641 -37
===========================================
- Hits 108351 108307 -44
- Misses 44827 44931 +104
Partials 5038 5038
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
left a comment
There was a problem hiding this comment.
just to add more suffer to you
…/useStatusItems.tsx Co-authored-by: dougfabris <devfabris@gmail.com>

Proposed changes (including videos or screenshots)
Restores Away as a manually selectable preset in the quick status menu, the custom status modal, and the account profile page.
Away had been hidden (shown only when the user was already on it) when presence and status text were still treated as one thing. Now that they're separated, Away is a valid standalone presence state again — independent of any custom status text.
The change removes the two filters that hid Away (
UserStatusMenu.tsx, shared by the modal + profile; anduseStatusItems.tsxfor the navbar) and restores the original order Online → Away → Busy → Offline. No backend change needed:awayis already accepted byusers.setStatusand preserved by the presence engine.Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit