chore(passport-x): declare passport-oauth1 exports for TS7

[ggazzo]

Summary

Fixes the ambient passport-oauth1 declaration in passport-x so InternalOAuthError resolves under TypeScript 7.

Why

The declaration mixed export = OAuthStrategy with a separate export { InternalOAuthError, ... }. TS7 rejects that combination, so import OAuthStrategy, { InternalOAuthError } from 'passport-oauth1' failed with TS2305 (no exported member). The runtime module does export it (exports.InternalOAuthError = ...).

Move the named members into a namespace OAuthStrategy merged with the default class — the canonical way to type a CommonJS module that has both module.exports = X and exports.Y. Green on both TS5.x and TS7.

Draft — part of the TS7-readiness set.

Task: ARCH-2244

Summary by CodeRabbit

• Bug Fixes
  • Corrected OAuth strategy type definitions for improved compatibility with TypeScript projects.
  • Organized OAuth-related types under the strategy namespace and aligned internal property typing.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4032d4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The OAuth1 TypeScript declarations now namespace related types under OAuthStrategy, update _oauth accordingly, and retain only the export = OAuthStrategy module export.

Changes

OAuth1 declaration namespace

Layer / File(s)	Summary
Namespace and internal type references packages/passport-x/src/passport-oauth1.d.ts	OAuthGetCallback, OAuthError, OAuthClient, and InternalOAuthError are declared within OAuthStrategy; _oauth references OAuthStrategy.OAuthClient, and the previous named exports are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: updating passport-oauth1 type exports for TypeScript 7 compatibility.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• ARCH-2244: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[ggazzo]

/jira ARCH-2200

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.65%. Comparing base (eb99fc4) to head (4032d4d).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #41311      +/-   ##
===========================================
- Coverage    68.68%   68.65%   -0.04%     
===========================================
  Files         4135     4135              
  Lines       160461   160461              
  Branches     29186    29231      +45     
===========================================
- Hits        110215   110162      -53     
- Misses       45137    45182      +45     
- Partials      5109     5117       +8     

Flag	Coverage Δ
e2e	58.81% <ø> (-0.06%)	⬇️
e2e-api	45.32% <ø> (-0.30%)	⬇️
unit	70.65% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}