chore: declare '*.css' side-effect imports (TS7 compat) - #41261
Conversation
TypeScript 7 errors (TS2882) on side-effect `import './x.css'` without a module declaration. Add the same ambient declaration already used in apps/meteor to gazzodown, fuselage-ui-kit, storybook-config, ui-client and pdf-worker. No-op on the current toolchain.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
|
| Layer / File(s) | Summary |
|---|---|
Ambient CSS module declarations ee/packages/pdf-worker/src/css.d.ts, packages/{fuselage-ui-kit,gazzodown,storybook-config,ui-client}/src/css.d.ts |
Adds declare module '*.css' with export = undefined in each package. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Suggested labels: type: chore
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly summarizes the main change: adding CSS side-effect import declarations for TypeScript 7 compatibility. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- ARCH-2232: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
/jira ARCH-2200 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41261 +/- ##
===========================================
- Coverage 69.11% 69.08% -0.04%
===========================================
Files 3660 3660
Lines 143543 143543
Branches 25735 25745 +10
===========================================
- Hits 99216 99164 -52
- Misses 40020 40072 +52
Partials 4307 4307
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Adds an ambient
declare module '*.css'to the packages that side-effect-import CSS but don't yet declare it:gazzodown,fuselage-ui-kit,storybook-config,ui-client,pdf-worker.Why
TypeScript 7's native compiler errors (
TS2882) on side-effect imports likeimport './x.css'when there's no module declaration for the extension. This mirrors the declaration already present inapps/meteor/client/definitions/css.d.ts.No-op on the current TypeScript 5.x toolchain (typecheck stays green); this is forward-compat groundwork for the TS7 migration.
Draft — part of a set of small, independent TS7-readiness PRs.
Task: ARCH-2232
Summary by CodeRabbit