refactor: Explicit component props (18/23) - #41217
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Member
Author
|
/jira ARCH-2200 |
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (90)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
|
| Layer / File(s) | Summary |
|---|---|
PDF worker ChatTranscript markup props exported ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/* |
BoldSpanProps, CodeSpanProps, EmojiSpanProps, InlineElementsProps, ItalicSpanProps, LinkSpanProps, and StrikeSpanProps are changed to exported types. |
fuselage-ui-kit block and context props exported packages/fuselage-ui-kit/src/blocks/*, packages/fuselage-ui-kit/src/contexts/AppIdContext.tsx |
ActionProps, ActionsBlockProps, CalloutBlockProps, ItemProps, ContextBlockProps, DividerBlockProps, ImageBlockProps, InfoCardProps, InputBlockProps, PreviewBlockProps, FieldsProps, SectionBlockProps, TabNavigationBlockProps, VideoConferenceBlockProps, and AppIdProviderProps are changed to exported types. |
fuselage-ui-kit element props exported packages/fuselage-ui-kit/src/elements/* |
Prop types for Button, ChannelsSelect, Checkbox, DatePicker, IconButton, Icon, Image, LinearScale, MarkdownText, MultiStaticSelect, Overflow, PlainText, PlainTextInput, RadioButton, StaticSelect, TimePicker, ToggleSwitch, MultiUsersSelect, and UsersSelect elements are changed to exported types; MarkdownTextElement and PlainTextElement gain new named prop type aliases replacing inline typing. |
fuselage-ui-kit surface and utility props exported packages/fuselage-ui-kit/src/surfaces/*, packages/fuselage-ui-kit/src/utils/UiKitComponent.tsx |
BannerSurfaceProps, ContextualBarSurfaceProps, MessageSurfaceProps, ModalSurfaceProps, SurfaceProps, and UiKitComponentProps are changed to exported types. |
gazzodown markup, block, code, and color props exported packages/gazzodown/src/Markup.tsx, .../PreviewMarkup.tsx, .../blocks/*, .../code/*, .../colors/* |
Prop types for Markup, PreviewMarkup, HeadingBlock, OrderedListBlock, ParagraphBlock, QuoteBlock, SpoilerBlock, TableBlock, TaskListBlock, UnorderedListBlock, CodeBlock, CodeElement, PreviewCodeBlock, PreviewCodeElement, ColorElement, and PreviewColorElement are changed to exported types. |
gazzodown inline element, emoji, katex, mention, and Timestamp props exported packages/gazzodown/src/elements/*, .../emoji/*, .../katex/*, .../mentions/* |
Prop types for BoldSpan, ImageElement, InlineElements, ItalicSpan, LinkSpan, PlainSpan, PreviewInlineElements, SpoilerSpan, StrikeSpan, Timestamp subcomponents (including new TimestampProps, TimeProps, RelativeTimeProps, etc.), emoji elements/blocks, katex elements/blocks, and mention elements are changed to exported types. |
livechat component props exported packages/livechat/src/components/Alert/index.tsx, .../Button/index.tsx |
AlertProps and ButtonProps are changed to exported types. |
Estimated code review effort: 2 (Simple) | ~15 minutes
Possibly related PRs
- RocketChat/Rocket.Chat#40809: Touches the same
ActionsBlock.Action.tsxand related fuselage-ui-kit typing in the same modules. - RocketChat/Rocket.Chat#40810: Touches the same
packages/gazzodown/src/**component files, changing typings in-place alongside this PR's export changes. - RocketChat/Rocket.Chat#41178: A similar TypeScript-only refactor exporting component prop type aliases without changing rendering logic.
Suggested reviewers: ggazzo, juliajforesti, dougfabris
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title matches the main change: exporting explicit component prop types across packages. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (2)
- ARCH-2222: Request failed with status code 401
- PROPS-18: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41217 +/- ##
===========================================
- Coverage 69.17% 69.15% -0.02%
===========================================
Files 3651 3651
Lines 142782 142782
Branches 25565 25584 +19
===========================================
- Hits 98765 98746 -19
- Misses 39728 39741 +13
- Partials 4289 4295 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
approved these changes
Jul 7, 2026
…lements): export component props types
…xport component props types
…: export component props types
…xport component props types
tassoevan
force-pushed
the
refactor/explicit-component-props-18
branch
from
July 7, 2026 23:31
eaefc80 to
57b4e76
Compare
tassoevan
added
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
cardoso
pushed a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It explicits the types for component props, following our guideline.
Issue(s)
Steps to test or reproduce
Further comments
Task: ARCH-2222
Summary by CodeRabbit