fix: grant actions:read permission to CI e2e test jobs - #41147
fix: grant actions:read permission to CI e2e test jobs#41147julio-rocketchat wants to merge 1 commit into
Conversation
The least-privilege permissions change (#40687) restricted ci.yml's GITHUB_TOKEN to contents:read, but the reusable ci-test-e2e.yml workflow it calls requires actions:read (needed by actions/download-artifact). Since a reusable workflow can't be granted more permissions than its caller has, this permission mismatch caused the entire CI workflow to fail at startup (startup_failure, 0 jobs scheduled) on every push/PR.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-04-27T18:32:21.871ZApplied to files:
🔇 Additional comments (1)
WalkthroughThis PR adds job-level ChangesCI e2e job permissions
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41147 +/- ##
===========================================
- Coverage 69.14% 69.13% -0.02%
===========================================
Files 3433 3433
Lines 132444 132444
Branches 23081 23106 +25
===========================================
- Hits 91579 91560 -19
- Misses 37502 37511 +9
- Partials 3363 3373 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
ci.yml'sGITHUB_TOKENtocontents: readat the workflow level.ci-test-e2e.yml(called byci.ymlviauses:) requiresactions: readat the job level (needed byactions/download-artifact), which exceeds the caller's granted permissions.CIon every push/PR since the merge (e.g. https://github.com/RocketChat/Rocket.Chat/actions/runs/28599899385,startup_failure, 0 jobs scheduled).Fix
Add
actions: read(alongsidecontents: read) at the job level inci.ymlfor the six jobs that callci-test-e2e.yml(test-api,test-api-livechat,test-ui,test-api-ee,test-api-livechat-ee,test-ui-ee), scoped only to those jobs rather than widening the workflow-level default.Test plan
CIworkflow schedules jobs (nostartup_failure) on this PRtest-api,test-api-livechat,test-ui,test-api-ee,test-api-livechat-ee,test-ui-eerun and passSummary by CodeRabbit