test: Flaky should display rooms in direct message filter

[dougfabris]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

FLAKY-1586

Summary by CodeRabbit

• Tests
  • Updated end-to-end coverage for creating discussions to use a more consistent dialog flow.
  • Improved test interactions around discussion creation in side panels and direct messages, helping reduce flaky behavior.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4b60d24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfb92c5c-dc8f-4ed2-9036-6e419578de2c

📥 Commits

Reviewing files that changed from the base of the PR and between 70c0ff0 and 4b60d24.

📒 Files selected for processing (4)

• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts
• apps/meteor/tests/e2e/page-objects/fragments/home-content.ts
• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts

💤 Files with no reviewable changes (1)

• apps/meteor/tests/e2e/page-objects/fragments/home-content.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout. (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Hacktron Security Check

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

apps/meteor/tests/e2e/page-objects/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

Utilize existing page objects pattern from apps/meteor/tests/e2e/page-objects/

Files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts

apps/meteor/tests/e2e/**/*.{ts,spec.ts}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.{ts,spec.ts}: Store commonly used locators in variables/constants for reuse
Follow Page Object Model pattern consistently in Playwright tests

Files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use .spec.ts extension for test files (e.g., login.spec.ts)

Files:

• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

apps/meteor/tests/e2e/**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.spec.ts: All test files must be created in apps/meteor/tests/e2e/ directory
Avoid using page.locator() in Playwright tests - always prefer semantic locators such as page.getByRole(), page.getByLabel(), page.getByText(), or page.getByTitle()
Use test.beforeAll() and test.afterAll() for setup/teardown in Playwright tests
Use test.step() for complex test scenarios to improve organization in Playwright tests
Group related tests in the same file
Utilize Playwright fixtures (test, page, expect) for consistency in test files
Prefer web-first assertions (toBeVisible, toHaveText, etc.) in Playwright tests
Use expect matchers for assertions (toEqual, toContain, toBeTruthy, toHaveLength, etc.) instead of assert statements in Playwright tests
Use page.waitFor() with specific conditions instead of hardcoded timeouts in Playwright tests
Implement proper wait strategies for dynamic content in Playwright tests
Maintain test isolation between test cases in Playwright tests
Ensure clean state for each test execution in Playwright tests
Ensure tests run reliably in parallel without shared state conflicts

Files:

• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

🧠 Learnings (7)

📚 Learning: 2025-12-16T17:29:40.430Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37834
File: apps/meteor/tests/e2e/page-objects/fragments/admin-flextab-emoji.ts:12-22
Timestamp: 2025-12-16T17:29:40.430Z
Learning: In all page-object files under apps/meteor/tests/e2e/page-objects/, import expect from ../../utils/test (Playwright's async expect) instead of from Jest. Jest's expect is synchronous and incompatible with web-first assertions like toBeVisible, which can cause TypeScript errors.

Applied to files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts

📚 Learning: 2026-02-24T19:39:42.247Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/message.ts:7-7
Timestamp: 2026-02-24T19:39:42.247Z
Learning: In RocketChat e2e tests, avoid using data-qa attributes to locate elements. Prefer semantic locators such as getByRole, getByLabel, getByText, getByTitle and ARIA-based selectors. Apply this rule to all TypeScript files under apps/meteor/tests/e2e to improve test reliability, accessibility, and maintainability.

Applied to files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

• apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts
• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

📚 Learning: 2026-02-24T19:22:48.358Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.

Applied to files:

• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

📚 Learning: 2026-03-06T18:10:15.268Z

Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.

Applied to files:

• apps/meteor/tests/e2e/channel-management.spec.ts
• apps/meteor/tests/e2e/feature-preview.spec.ts

🔇 Additional comments (3)

apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts (1)

49-52: LGTM!

apps/meteor/tests/e2e/channel-management.spec.ts (1)

6-6: LGTM!

Also applies to: 147-157

apps/meteor/tests/e2e/feature-preview.spec.ts (1)

5-5: LGTM!

Also applies to: 240-252, 559-581

---

Walkthrough

E2e discussion-creation tests are refactored to use a CreateNewDiscussionModal page object instead of directly interacting with HomeContent composer inputs. CreateNewModal gains a create() method, and now-unused discussion modal getters are removed from HomeContent.

Changes

Discussion modal migration

Layer / File(s)	Summary
CreateNewModal create() method and getter cleanup apps/meteor/tests/e2e/page-objects/fragments/modals/create-new-modal.ts, apps/meteor/tests/e2e/page-objects/fragments/home-content.ts	CreateNewModal.create() is added to click the Create button and wait for dismissal; HomeContent removes the createDiscussionModal, inputDiscussionName, and btnCreateDiscussionModal getters.
E2e spec updates for discussion creation flows apps/meteor/tests/e2e/channel-management.spec.ts, apps/meteor/tests/e2e/feature-preview.spec.ts	Tests import CreateNewDiscussionModal and replace composer-based input/button interactions with inputName.fill() and create() across the message composer, sidepanel, and DM discussion creation test flows.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: type: chore

Suggested reviewers: tassoevan, gabriellsh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is specific and related to the changed direct-message filter e2e test, even if it doesn't mention the modal-dismiss fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• FLAKY-1586: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.12%. Comparing base (3001445) to head (4b60d24).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #41137      +/-   ##
===========================================
+ Coverage    69.10%   69.12%   +0.01%     
===========================================
  Files         3433     3433              
  Lines       132323   132340      +17     
  Branches     23068    23144      +76     
===========================================
+ Hits         91438    91474      +36     
+ Misses       37513    37496      -17     
+ Partials      3372     3370       -2     

Flag	Coverage Δ
e2e	59.37% <ø> (+0.02%)	⬆️
e2e-api	40.47% <ø> (+0.06%)	⬆️
unit	69.95% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

No issues found across 4 files

_{Re-trigger cubic}