Skip to content

chore: Change navbar's search input icon size - #41042

Merged
ggazzo merged 1 commit into
developfrom
chore/navbar-addon-size
Jun 23, 2026
Merged

chore: Change navbar's search input icon size#41042
ggazzo merged 1 commit into
developfrom
chore/navbar-addon-size

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 22, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Change the icon size to be equal the clear button, avoiding navbar resizing

before

Kapture 2026-06-22 at 14 34 24

after

Kapture 2026-06-22 at 14 33 23

Issue(s)

Steps to test or reproduce

Further comments

CORE-2309

Review in cubic

Summary by CodeRabbit

  • Style
    • Increased the size of the search icon in the navigation bar for improved visibility.

@dionisio-bot

dionisio-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 8.7.0, but it targets 8.6.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2842271

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The magnifier icon rendered inside the TextInput addon in NavBarSearch.tsx has its size prop changed from x16 to x20 for the non-dirty (default) state. No logic, handlers, or other component behavior are modified.

Changes

NavBar Search Icon Size

Layer / File(s) Summary
Search icon size
apps/meteor/client/navbar/NavBarSearch/NavBarSearch.tsx
Magnifier icon size prop updated from x16 to x20 in the non-dirty TextInput addon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adjusting the navbar search input icon size from x16 to x20.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • F20B-4791: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dougfabris dougfabris added this to the 8.7.0 milestone Jun 22, 2026
@dougfabris dougfabris changed the title chore: Change navbar search input icon size chore: Change navbar's search input icon size Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.15%. Comparing base (ffaa115) to head (2842271).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41042      +/-   ##
===========================================
- Coverage    70.16%   70.15%   -0.02%     
===========================================
  Files         3361     3361              
  Lines       129690   129690              
  Branches     22490    22465      -25     
===========================================
- Hits         91000    90978      -22     
- Misses       35378    35398      +20     
- Partials      3312     3314       +2     
Flag Coverage Δ
e2e 59.32% <ø> (-0.12%) ⬇️
e2e-api 47.12% <ø> (+0.76%) ⬆️
unit 70.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris
dougfabris marked this pull request as ready for review June 22, 2026 18:56
@dougfabris
dougfabris requested a review from a team as a code owner June 22, 2026 18:56
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 22, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@dougfabris dougfabris modified the milestones: 8.7.0, 8.6.0 Jun 22, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 22, 2026
@alfredodelfabro alfredodelfabro modified the milestones: 8.6.0, 8.7.0 Jun 23, 2026
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris modified the milestones: 8.7.0, 8.6.0 Jun 23, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jun 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@dougfabris dougfabris removed the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2026
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris removed this from the 8.6.0 milestone Jun 23, 2026
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris added this to the 8.6.0 milestone Jun 23, 2026
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jun 23, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris modified the milestones: 8.6.0, 8.7.0 Jun 23, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jun 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@dougfabris dougfabris removed the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2026
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2026
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jun 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jun 23, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jun 23, 2026
@ggazzo
ggazzo removed this pull request from the merge queue due to a manual request Jun 23, 2026
@ggazzo
ggazzo merged commit 5620611 into develop Jun 23, 2026
82 of 85 checks passed
@ggazzo
ggazzo deleted the chore/navbar-addon-size branch June 23, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants