refactor(ui-voip): extract PeerCardsView from MediaCallRoomSection - #41041
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughPeer card rendering is extracted from ChangesPeerCardsView extraction
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41041 +/- ##
===========================================
- Coverage 70.19% 70.16% -0.03%
===========================================
Files 3360 3361 +1
Lines 129668 129690 +22
Branches 22485 22506 +21
===========================================
- Hits 91017 91000 -17
- Misses 35339 35375 +36
- Partials 3312 3315 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
86d73f0 to
c89688e
Compare
Pure refactor — extracts the peer cards rendering (cards, screen-share stream cards, focus handling, and the popout "show call here" state) out of
MediaCallRoomSectioninto a dedicatedPeerCardsViewcomponent. No behavior change.This extraction was originally bundled inside the voice-to-video escalation work (#40983, via #40869). Splitting it out as a standalone refactor keeps #40983's diff focused on the new escalation behavior — there
MediaCallRoomSectionnow only adds the escalation button/state and theVideoEscalatedViewswap on top of this component.Summary by CodeRabbit
related to DMV-17 I