chore: use @rocket.chat/logger in presence service - #41034
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
WalkthroughThe ChangesPresence Logger Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41034 +/- ##
===========================================
- Coverage 70.12% 70.10% -0.02%
===========================================
Files 3357 3360 +3
Lines 129552 129673 +121
Branches 22407 22507 +100
===========================================
+ Hits 90843 90912 +69
- Misses 35416 35448 +32
- Partials 3293 3313 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
b94ee10 to
f5d82b1
Compare
commit b1e5eba Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Thu Jun 25 13:07:19 2026 -0300 test(apps): clean deno-runtime temp link before running commit c39875e Author: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Date: Fri Jun 5 17:57:10 2026 +0000 test(apps): preserve _id and support _id partial updates in test storage commit 114e5e7 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 16:37:07 2026 -0300 chore: add @RocketChat/apps as codeowner of more paths commit 28a45be Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 15:54:13 2026 -0300 chore(apps): loosen permissions for deno test commit 1895ed4 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 15:46:33 2026 -0300 chore(apps): replace nedb in tests for custom mock fix mock commit 660215a Author: Ricardo Garim <rswarovsky@gmail.com> Date: Thu Jun 25 11:06:59 2026 -0300 chore: use @rocket.chat/logger in presence service (#41034)
commit b1e5eba Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Thu Jun 25 13:07:19 2026 -0300 test(apps): clean deno-runtime temp link before running commit c39875e Author: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Date: Fri Jun 5 17:57:10 2026 +0000 test(apps): preserve _id and support _id partial updates in test storage commit 114e5e7 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 16:37:07 2026 -0300 chore: add @RocketChat/apps as codeowner of more paths commit 28a45be Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 15:54:13 2026 -0300 chore(apps): loosen permissions for deno test commit 1895ed4 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Wed Jun 3 15:46:33 2026 -0300 chore(apps): replace nedb in tests for custom mock fix mock commit 660215a Author: Ricardo Garim <rswarovsky@gmail.com> Date: Thu Jun 25 11:06:59 2026 -0300 chore: use @rocket.chat/logger in presence service (#41034)
Proposed changes (including videos or screenshots)
Replace the raw
console.*calls in@rocket.chat/presence(Presence.ts,PresenceReaper.ts) with structured@rocket.chat/loggerinstances.Issue(s)
Steps to test or reproduce
Further comments
Logging-only migration, no behavior change. No Dockerfile edit needed —
@rocket.chat/loggeris already a dependency of presence-service and copied into its build.Summary by CodeRabbit