test: flaky session-expiration-redirect.spec

[gabriellsh]

Proposed changes (including videos or screenshots)

There was no assertion waiting for the room to load, so before the app would finish making all requests, the tokens would be removed from the database, causing remaining requests to redirect the user to the login page before the message search button could be clicked.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Tests
  • Enhanced session expiration redirect testing with improved setup procedures, refined user targeting logic, optimized navigation patterns, and streamlined assertion mechanisms to increase test reliability and maintainability.

Task: FLAKY-2127

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is targeting the wrong base branch. It should target 8.7.0, but it targets 8.6.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: c5a03c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The session-expiration-redirect E2E spec removes restoreState from the fixture import, switches channel creation to use Users.user1.data.username, adds poHomeChannel.gotoChannel in beforeEach, drops the restoreState call from afterEach, and simplifies both login form redirect assertions to direct toBeVisible() calls.

Changes

Session Expiration Redirect E2E Test

Layer / File(s)	Summary
Test setup, lifecycle, and redirect assertions apps/meteor/tests/e2e/session-expiration-redirect.spec.ts	Removes restoreState from the userStates import, changes channel creation member to Users.user1.data.username, adds poHomeChannel.gotoChannel(targetChannel) to beforeEach, removes restoreState from afterEach, and replaces waitFor-with-timeout redirect checks with direct expect(...).toBeVisible() assertions for the Login form in both test cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• RocketChat/Rocket.Chat#40849: Directly targets the same expired-session redirect E2E test file and token-expiration behavior that this PR adjusts.

Suggested labels

type: chore

Suggested reviewers

• ggazzo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title directly and clearly describes the main objective: fixing flakiness in the session-expiration-redirect.spec test file, which aligns with the changeset's purpose of addressing race conditions and test reliability issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

1 issue found across 1 file

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.12%. Comparing base (fa685d0) to head (cd067e2).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #41018      +/-   ##
===========================================
+ Coverage    70.11%   70.12%   +0.01%     
===========================================
  Files         3359     3359              
  Lines       129609   129609              
  Branches     22464    22434      -30     
===========================================
+ Hits         90878    90891      +13     
+ Misses       35422    35406      -16     
- Partials      3309     3312       +3     

Flag	Coverage Δ
e2e	59.30% <ø> (-0.03%)	⬇️
e2e-api	47.07% <ø> (+0.86%)	⬆️
unit	70.04% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gabriellsh]

/jira FLAKY