Skip to content

Revert "refactor: Remove unused description from attachments render" (#40067) - #40935

Merged
julio-rocketchat merged 1 commit into
release-8.5.1from
backport-8.5.1-40860
Jun 12, 2026
Merged

Revert "refactor: Remove unused description from attachments render" (#40067)#40935
julio-rocketchat merged 1 commit into
release-8.5.1from
backport-8.5.1-40860

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Backport of #40860

Review in cubic

@dionisio-bot
dionisio-bot Bot requested review from a team as code owners June 12, 2026 14:05
@dionisio-bot
dionisio-bot Bot requested a review from dougfabris June 12, 2026 14:05
@dionisio-bot dionisio-bot Bot added the backport Used to inform backported PR label Jun 12, 2026
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ecb23aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.68293% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.95%. Comparing base (f24b953) to head (ecb23aa).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.5.1   #40935      +/-   ##
=================================================
- Coverage          69.95%   69.95%   -0.01%     
=================================================
  Files               3330     3330              
  Lines             127163   127227      +64     
  Branches           22113    22119       +6     
=================================================
+ Hits               88958    89001      +43     
- Misses             34892    34913      +21     
  Partials            3313     3313              
Flag Coverage Δ
e2e 59.28% <8.33%> (-0.04%) ⬇️
e2e-api 46.11% <50.00%> (+0.03%) ⬆️
unit 70.04% <52.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 12, 2026
@alfredodelfabro alfredodelfabro added the stat: ready to merge PR tested and approved waiting for merge label Jun 12, 2026
@julio-rocketchat
julio-rocketchat merged commit 4ff7cd6 into release-8.5.1 Jun 12, 2026
45 of 46 checks passed
@julio-rocketchat
julio-rocketchat deleted the backport-8.5.1-40860 branch June 12, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR community stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants