chore(deps): bump ip-address, ws, grpc-js - #40914
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
WalkthroughUpdate ChangesDependency version updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40914 +/- ##
===========================================
- Coverage 70.16% 70.14% -0.02%
===========================================
Files 3355 3355
Lines 129196 129196
Branches 22375 22401 +26
===========================================
- Hits 90644 90622 -22
- Misses 35270 35276 +6
- Partials 3282 3298 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 92: The package.json currently allows floating updates for the socks
dependency ("socks": "^2.8.9"), so verify the package lifecycle scripts and
supply-chain risk and either pin to the exact vetted release ("socks": "2.8.9")
or otherwise lock the dependency range; specifically inspect the socks package
metadata and any install scripts (the "socks" package entry) and replace the
caret range with an exact version or a pinned range after confirming no
problematic lifecycle scripts or upstream advisories.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 76801332-5c15-4a40-8b6e-610cc43670c2
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
apps/meteor/ee/server/services/package.jsonee/apps/ddp-streamer/package.jsonpackage.jsonpackages/ddp-client/package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
🔇 Additional comments (5)
ee/apps/ddp-streamer/package.json (1)
49-49: Duplicate: ws version verification covered in apps/meteor/ee/server/services/package.json.This ws version update is part of the same dependency bump. The version verification and security check are covered in the comment on
apps/meteor/ee/server/services/package.jsonline 47.packages/ddp-client/package.json (1)
33-33: Duplicate: ws version verification covered in apps/meteor/ee/server/services/package.json.This ws devDependency update is part of the same dependency bump. The version verification and security check are covered in the comment on
apps/meteor/ee/server/services/package.jsonline 47.package.json (2)
163-166: Verify@grpc/grpc-js^1.14.4 compatibility with OpenTelemetry OTLP gRPC exporters (package.json lines 163-166)
- npm registry contains
@grpc/grpc-js@1.14.4✅- Security advisories: the GitHub GraphQL query fails with
401 Requires authentication, so this can’t be assessed from the current check ❌- Compatibility: peer-dependency metadata from
.../latestfor the mentioned@opentelemetry/*packages didn’t report a required@grpc/grpc-jsversion, so compatibility still needs to be validated against the exact OpenTelemetry exporter versions used in this repo (package.json/lockfile), not justlatest.
94-96: ws “mismatch” doesn’t exist in practice: yarn.lock resolveswsto8.21.0Root
resolutionspinwsto^8.20.1, which still allows8.21.0(so it overlaps with the packages’~8.21.0). The existingyarn.lockcontains an entry like"ws@npm:^8.20.1, ws@npm:~8.21.0": ... resolution: "ws@npm:8.21.0", so the resolved version matches the~8.21.0package declarations.> Likely an incorrect or invalid review comment.apps/meteor/ee/server/services/package.json (1)
47-47: ws@8.21.0: present on npm; vulnerability check couldn’t be completed (401)The below code does not show removed or replaced code.
"ws": "~8.21.0"
- npm registry contains
ws@8.21.0(andws@8.20.1).- The security advisory query (
gh api graphql ... securityVulnerabilities) returned401 Requires authentication, so known-vulnerability status forws@8.21.0wasn’t established.- The “conflicts with root resolution” note (root
package.jsonlines 94-96) wasn’t evaluated in the provided checks; confirm the effective resolved version fromyarn.lock.
|
/backport 8.5.1 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat>
|
/backport 8.5.1 |
|
Pull request #40933 added to Project: "Patch 8.5.1" |
Proposed changes (including videos or screenshots)
This PR updates ws, ip-address, and @grpc-grpc-js to address related CVEs.
Issue(s)
https://rocketchat.atlassian.net/browse/SB-998
Steps to test or reproduce
Further comments
Summary by CodeRabbit
@grpc/grpc-js^1.14.4 for consistent telemetry.