Skip to content

fix: add missing authorization check to fingerprint endpoint - #40911

Merged
julio-rocketchat merged 2 commits into
release-7.13.9from
backport-7.13.9-40706
Jun 12, 2026
Merged

fix: add missing authorization check to fingerprint endpoint#40911
julio-rocketchat merged 2 commits into
release-7.13.9from
backport-7.13.9-40706

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Backport of #40706

@dionisio-bot
dionisio-bot Bot requested a review from a team as a code owner June 11, 2026 19:22
@dionisio-bot
dionisio-bot Bot requested a review from ricardogarim June 11, 2026 19:22
@dionisio-bot dionisio-bot Bot added the backport Used to inform backported PR label Jun 11, 2026
@changeset-bot

changeset-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9475386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

📦 Docker Image Size Report

📉 Changes

Service Current Baseline Change Percent
sum of all images 0B 1.2GiB -1.2GiB
account-service 0B 122MiB -122MiB
authorization-service 0B 121MiB -121MiB
ddp-streamer-service 0B 136MiB -136MiB
omnichannel-transcript-service 0B 143MiB -143MiB
presence-service 0B 120MiB -120MiB
queue-worker-service 0B 143MiB -143MiB
rocketchat 0B 295MiB -295MiB
stream-hub-service 0B 111MiB -111MiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["05/04 23:47", "05/05 23:54", "05/06 23:38", "05/07 19:16", "05/08 23:25", "05/11 23:38", "05/12 20:56", "05/13 20:48", "05/14 22:19", "05/15 20:08", "05/16 03:18", "05/17 01:40", "05/18 20:06", "05/19 23:19", "05/20 20:44", "05/21 13:26", "05/22 16:32", "05/25 20:35", "05/26 22:56", "05/27 19:48", "05/28 18:02", "05/29 20:31", "06/02 23:30", "06/03 22:13", "06/04 22:11", "06/05 23:44", "06/08 23:35", "06/09 23:07", "06/10 21:50", "06/11 20:02", "06/11 21:39 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "authorization-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "ddp-streamer-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.00]
  line "rocketchat" [0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.00]
  line "stream-hub-service" [0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.4GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.4GiB
  • 🎯 Current PR: 0B
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-40911
  • Baseline: develop
  • Timestamp: 2026-06-11 21:39:10 UTC
  • Historical data points: 30

Updated: Thu, 11 Jun 2026 21:39:11 GMT

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dionisio-bot

dionisio-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-7.13.9@35c0d83). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-7.13.9   #40911   +/-   ##
=================================================
  Coverage                  ?   67.79%           
=================================================
  Files                     ?     3445           
  Lines                     ?   113934           
  Branches                  ?    20845           
=================================================
  Hits                      ?    77246           
  Misses                    ?    34576           
  Partials                  ?     2112           
Flag Coverage Δ
e2e 57.43% <ø> (?)
e2e-api 42.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat
julio-rocketchat merged commit e542e13 into release-7.13.9 Jun 12, 2026
150 of 156 checks passed
@julio-rocketchat
julio-rocketchat deleted the backport-7.13.9-40706 branch June 12, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants