chore!: remove WebDav integration - #40856
Merged
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 08a442e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (64)
💤 Files with no reviewable changes (60)
🚧 Files skipped from review as they are similar to previous changes (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
Shared contracts and models packages/core-typings/..., packages/core-services/..., packages/ddp-client/..., packages/model-typings/..., packages/models/... |
WebDAV account types, model interfaces, model exports, upload storage fields, and event stream contracts are removed. |
Server runtime and settings apps/meteor/server/..., apps/meteor/package.json |
WebDAV server initialization, model registration, notification handling, storage options, WebDAV settings, Nextcloud bridge setup, and the webdav dependency are removed. |
Client actions and account UI apps/meteor/client/components/message/..., apps/meteor/client/views/account/..., apps/meteor/client/views/room/... |
WebDAV message/composer actions, account integrations routes, sidebar entry, modals, file picker, and related hooks are removed. |
Upgrade migration apps/meteor/server/startup/migrations/..., apps/meteor/jest.config.ts, .changeset/remove-webdav-integration.md |
Migration v336 blocks upgrades configured for WebDAV storage or deletes WebDAV settings, and migration test discovery and release metadata are added. |
Estimated code review effort: 4 (Complex) | ~45 minutes
Possibly related PRs
- RocketChat/Rocket.Chat#41115: Modifies import wiring in the same WebDAV bridge and method areas.
Suggested labels: type: chore
Suggested reviewers: tassoevan, sampaiodiego
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly matches the PR’s main change: removing WebDAV integration. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- VLN-345: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-9.0.0 #40856 +/- ##
=================================================
+ Coverage 68.49% 68.65% +0.15%
=================================================
Files 4089 4061 -28
Lines 157953 157400 -553
Branches 28595 28455 -140
=================================================
- Hits 108193 108063 -130
+ Misses 44741 44324 -417
+ Partials 5019 5013 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
force-pushed
the
webdav-integration-removal
branch
from
June 12, 2026 02:23
d155f77 to
9613065
Compare
julio-rocketchat
marked this pull request as ready for review
June 30, 2026 10:14
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/meteor/server/startup/migrations/v336.spec.ts`:
- Around line 70-73: The test in v336.spec.ts is using an invalid matcher for a
Promise<void> returned by up(), so replace the resolves.not.toThrow assertion
with a resolved-value matcher that checks for undefined. Update the expectation
in the “does not throw when storage type is AmazonS3” case to assert the promise
resolves successfully, using the up() call and its resolved value directly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0c30d238-18e7-42e8-8a9f-7d6d1ca90486
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (64)
apps/meteor/app/api/server/index.tsapps/meteor/app/api/server/lib/webdav.tsapps/meteor/app/api/server/v1/webdav.tsapps/meteor/app/file-upload/server/config/Webdav.tsapps/meteor/app/file-upload/server/config/_configUploadStorage.tsapps/meteor/app/file-upload/ufs/Webdav/server.tsapps/meteor/app/nextcloud/server/addWebdavServer.tsapps/meteor/app/nextcloud/server/index.tsapps/meteor/app/webdav/README.mdapps/meteor/app/webdav/server/index.tsapps/meteor/app/webdav/server/lib/getWebdavCredentials.tsapps/meteor/app/webdav/server/lib/uploadFileToWebdav.tsapps/meteor/app/webdav/server/lib/webdavClientAdapter.tsapps/meteor/app/webdav/server/methods/addWebdavAccount.tsapps/meteor/app/webdav/server/methods/getFileFromWebdav.tsapps/meteor/app/webdav/server/methods/getWebdavFileList.tsapps/meteor/app/webdav/server/methods/getWebdavFilePreview.tsapps/meteor/app/webdav/server/methods/uploadFileToWebdav.tsapps/meteor/client/components/message/toolbar/MessageToolbarActionMenu.tsxapps/meteor/client/components/message/toolbar/useWebDAVMessageAction.tsxapps/meteor/client/hooks/webdav/useWebDAVAccountIntegrationsQuery.tsapps/meteor/client/lib/getWebdavServerName.tsapps/meteor/client/views/account/integrations/AccountIntegrationsPage.tsxapps/meteor/client/views/account/integrations/AccountIntegrationsRoute.tsxapps/meteor/client/views/account/integrations/hooks/useRemoveWebDAVAccountIntegrationMutation.tsapps/meteor/client/views/account/routes.tsxapps/meteor/client/views/account/sidebarItems.tsxapps/meteor/client/views/room/composer/messageBox/MessageBoxActionsToolbar/MessageBoxActionsToolbar.tsxapps/meteor/client/views/room/composer/messageBox/MessageBoxActionsToolbar/hooks/useWebdavActions.tsxapps/meteor/client/views/room/webdav/AddWebdavAccountModal.tsxapps/meteor/client/views/room/webdav/SaveToWebdavModal.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/FilePickerBreadcrumbs.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/WebdavFilePickerGrid.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/WebdavFilePickerGridItem.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/index.tsapps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerModal.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerTable.tsxapps/meteor/client/views/room/webdav/WebdavFilePickerModal/index.tsapps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeFileSize.tsapps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.spec.tsapps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.tsapps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/sortWebdavNodes.tsapps/meteor/jest.config.tsapps/meteor/package.jsonapps/meteor/server/importPackages.tsapps/meteor/server/models.tsapps/meteor/server/modules/listeners/listeners.module.tsapps/meteor/server/settings/file-upload.tsapps/meteor/server/settings/index.tsapps/meteor/server/settings/webdav.tsapps/meteor/server/startup/migrations/index.tsapps/meteor/server/startup/migrations/v336.spec.tsapps/meteor/server/startup/migrations/v336.tsapps/meteor/tests/end-to-end/api/webdav.tspackages/core-services/src/events/Events.tspackages/core-typings/src/IUpload.tspackages/core-typings/src/IWebdavAccount.tspackages/core-typings/src/index.tspackages/ddp-client/src/types/streams.tspackages/model-typings/src/index.tspackages/model-typings/src/models/IWebdavAccountsModel.tspackages/models/src/index.tspackages/models/src/modelClasses.tspackages/models/src/models/WebdavAccounts.ts
💤 Files with no reviewable changes (60)
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeFileSize.ts
- apps/meteor/client/views/account/integrations/AccountIntegrationsRoute.tsx
- packages/models/src/models/WebdavAccounts.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/WebdavFilePickerGridItem.tsx
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.ts
- apps/meteor/client/views/room/composer/messageBox/MessageBoxActionsToolbar/hooks/useWebdavActions.tsx
- apps/meteor/client/views/account/integrations/hooks/useRemoveWebDAVAccountIntegrationMutation.ts
- apps/meteor/client/views/account/integrations/AccountIntegrationsPage.tsx
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/index.ts
- apps/meteor/client/views/room/webdav/SaveToWebdavModal.tsx
- apps/meteor/client/lib/getWebdavServerName.ts
- packages/core-typings/src/index.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/index.ts
- packages/model-typings/src/models/IWebdavAccountsModel.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.spec.ts
- apps/meteor/server/importPackages.ts
- apps/meteor/app/file-upload/server/config/Webdav.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerGrid/WebdavFilePickerGrid.tsx
- apps/meteor/app/webdav/README.md
- apps/meteor/app/api/server/index.ts
- apps/meteor/app/nextcloud/server/index.ts
- apps/meteor/server/settings/webdav.ts
- packages/model-typings/src/index.ts
- apps/meteor/app/webdav/server/methods/getWebdavFilePreview.ts
- packages/core-typings/src/IUpload.ts
- apps/meteor/client/components/message/toolbar/useWebDAVMessageAction.tsx
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/sortWebdavNodes.ts
- apps/meteor/app/file-upload/ufs/Webdav/server.ts
- apps/meteor/app/webdav/server/lib/webdavClientAdapter.ts
- apps/meteor/app/webdav/server/methods/getFileFromWebdav.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/FilePickerBreadcrumbs.tsx
- apps/meteor/app/webdav/server/index.ts
- apps/meteor/tests/end-to-end/api/webdav.ts
- apps/meteor/package.json
- packages/core-typings/src/IWebdavAccount.ts
- apps/meteor/app/webdav/server/methods/uploadFileToWebdav.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerTable.tsx
- apps/meteor/app/webdav/server/lib/uploadFileToWebdav.ts
- packages/core-services/src/events/Events.ts
- apps/meteor/app/file-upload/server/config/_configUploadStorage.ts
- apps/meteor/client/views/room/composer/messageBox/MessageBoxActionsToolbar/MessageBoxActionsToolbar.tsx
- apps/meteor/app/webdav/server/methods/addWebdavAccount.ts
- packages/models/src/modelClasses.ts
- apps/meteor/app/api/server/lib/webdav.ts
- apps/meteor/client/views/room/webdav/AddWebdavAccountModal.tsx
- apps/meteor/app/webdav/server/methods/getWebdavFileList.ts
- apps/meteor/app/api/server/v1/webdav.ts
- apps/meteor/server/models.ts
- apps/meteor/server/modules/listeners/listeners.module.ts
- apps/meteor/client/components/message/toolbar/MessageToolbarActionMenu.tsx
- apps/meteor/app/nextcloud/server/addWebdavServer.ts
- apps/meteor/client/hooks/webdav/useWebDAVAccountIntegrationsQuery.ts
- apps/meteor/client/views/account/routes.tsx
- packages/ddp-client/src/types/streams.ts
- apps/meteor/client/views/room/webdav/WebdavFilePickerModal/WebdavFilePickerModal.tsx
- apps/meteor/app/webdav/server/lib/getWebdavCredentials.ts
- packages/models/src/index.ts
- apps/meteor/client/views/account/sidebarItems.tsx
- apps/meteor/server/settings/file-upload.ts
- apps/meteor/server/settings/index.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/server/startup/migrations/index.tsapps/meteor/jest.config.tsapps/meteor/server/startup/migrations/v336.spec.tsapps/meteor/server/startup/migrations/v336.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/server/startup/migrations/v336.spec.ts
🧠 Learnings (5)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/server/startup/migrations/index.tsapps/meteor/jest.config.tsapps/meteor/server/startup/migrations/v336.spec.tsapps/meteor/server/startup/migrations/v336.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/server/startup/migrations/index.tsapps/meteor/jest.config.tsapps/meteor/server/startup/migrations/v336.spec.tsapps/meteor/server/startup/migrations/v336.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/server/startup/migrations/index.tsapps/meteor/jest.config.tsapps/meteor/server/startup/migrations/v336.spec.tsapps/meteor/server/startup/migrations/v336.ts
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
apps/meteor/server/startup/migrations/v336.spec.ts
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
apps/meteor/server/startup/migrations/v336.spec.ts
🔇 Additional comments (4)
apps/meteor/server/startup/migrations/v336.ts (1)
1-47: LGTM!apps/meteor/server/startup/migrations/index.ts (1)
44-44: LGTM!apps/meteor/server/startup/migrations/v336.spec.ts (1)
1-68: LGTM!apps/meteor/jest.config.ts (1)
48-48: LGTM!
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 65 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
KevLehman
requested changes
Jul 1, 2026
Member
|
|
KevLehman
approved these changes
Jul 7, 2026
ricardogarim
force-pushed
the
release-9.0.0
branch
from
July 16, 2026 01:13
67bd907 to
02064cf
Compare
ggazzo
force-pushed
the
webdav-integration-removal
branch
from
July 17, 2026 18:48
6a4fea5 to
a69eab5
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/remove-webdav-integration.md:
- Line 5: Update the changeset description to clarify that upgrades with active
WebDAV storage are blocked before obsolete settings are deleted; state that
users must change the storage backend first, after which the WebDAV settings are
removed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 86dd4f73-6b78-4119-9d48-f9af1ed1ea51
📒 Files selected for processing (1)
.changeset/remove-webdav-integration.md
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
⚠️ CI failures not shown inline (5)
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-03-16T21:50:37.589Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:37.589Z
Learning: For changes related to OpenAPI migrations in Rocket.Chat/OpenAPI, when removing endpoint types and validators from rocket.chat/rest-typings (e.g., UserRegisterParamsPOST, /v1/users.register) document this as a minor changeset (not breaking) per RocketChat/Rocket.Chat-Open-API#150 Rule 7. Note that the endpoint type is re-exposed via a module augmentation .d.ts in the consuming package (e.g., packages/web-ui-registration/src/users-register.d.ts). In reviews, ensure the changeset clearly states: this is a non-breaking change, the major version should not be bumped, and the changeset reflects a minor version bump. Do not treat this as a breaking change during OpenAPI migrations.
Applied to files:
.changeset/remove-webdav-integration.md
| '@rocket.chat/meteor': major | ||
| --- | ||
|
|
||
| Removes the WebDAV integration. All WebDAV accounts, settings, and file-picker functionality have been removed, and existing WebDAV settings are cleared from the database on upgrade |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Clarify the upgrade behavior for active WebDAV workspaces.
The migration throws before deleting settings when FileUpload_Storage_Type is Webdav, so those settings are not cleared during that upgrade attempt. Mention that upgrades are blocked until the storage backend is changed, after which obsolete settings are removed.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/remove-webdav-integration.md at line 5, Update the changeset
description to clarify that upgrades with active WebDAV storage are blocked
before obsolete settings are deleted; state that users must change the storage
backend first, after which the WebDAV settings are removed.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".changeset/remove-webdav-integration.md">
<violation number="1" location=".changeset/remove-webdav-integration.md:5">
P3: The changeset description states that "existing WebDAV settings are cleared from the database on upgrade," but the migration actually blocks the upgrade when `FileUpload_Storage_Type` is still set to `Webdav`. This makes the description incomplete/misleading. Consider clarifying that upgrades are blocked until the storage backend is changed away from WebDAV, after which the obsolete settings are removed.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| '@rocket.chat/meteor': major | ||
| --- | ||
|
|
||
| Removes the WebDAV integration. All WebDAV accounts, settings, and file-picker functionality have been removed, and existing WebDAV settings are cleared from the database on upgrade |
Contributor
There was a problem hiding this comment.
P3: The changeset description states that "existing WebDAV settings are cleared from the database on upgrade," but the migration actually blocks the upgrade when FileUpload_Storage_Type is still set to Webdav. This makes the description incomplete/misleading. Consider clarifying that upgrades are blocked until the storage backend is changed away from WebDAV, after which the obsolete settings are removed.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .changeset/remove-webdav-integration.md, line 5:
<comment>The changeset description states that "existing WebDAV settings are cleared from the database on upgrade," but the migration actually blocks the upgrade when `FileUpload_Storage_Type` is still set to `Webdav`. This makes the description incomplete/misleading. Consider clarifying that upgrades are blocked until the storage backend is changed away from WebDAV, after which the obsolete settings are removed.</comment>
<file context>
@@ -0,0 +1,5 @@
+'@rocket.chat/meteor': major
+---
+
+Removes the WebDAV integration. All WebDAV accounts, settings, and file-picker functionality have been removed, and existing WebDAV settings are cleared from the database on upgrade
</file context>
ggazzo
approved these changes
Jul 17, 2026
ggazzo
force-pushed
the
webdav-integration-removal
branch
from
July 18, 2026 00:28
077a802 to
08a442e
Compare
ggazzo
added a commit
that referenced
this pull request
Jul 21, 2026
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo
added a commit
that referenced
this pull request
Aug 5, 2026
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Draft
tassoevan
pushed a commit
that referenced
this pull request
Aug 25, 2026
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
tassoevan
pushed a commit
that referenced
this pull request
Aug 27, 2026
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
tassoevan
pushed a commit
that referenced
this pull request
Aug 27, 2026
Co-authored-by: Julio Araujo <julio.araujo@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR removes the WebDAV integration from the codebase.
WebDAV has been officially deprecated in Rocket.Chat and is already scheduled to be removed in upcoming versions, as announced in our documentation. Additionally, the integration relied on third-party libraries that have had recurring security vulnerabilities (CVEs), making its removal also a security improvement.
WebDAV support is no longer available after this change.
Changes implemented:
Issue(s)
VLN-345
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Breaking Changes
Chores