Skip to content

chore: Passport Google OAuth - #40222

Merged
yash-rajpal merged 3 commits into
feat/phishing-resistant-mfafrom
passport-google
Apr 21, 2026
Merged

chore: Passport Google OAuth#40222
yash-rajpal merged 3 commits into
feat/phishing-resistant-mfafrom
passport-google

Conversation

@yash-rajpal

@yash-rajpal yash-rajpal commented Apr 19, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

PRM-26

Summary by CodeRabbit

  • New Features
    • Google OAuth authentication provider added with email and profile scope access.

@dionisio-bot

dionisio-bot Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Added Google OAuth support by introducing the passport-google-oauth20 npm package and its TypeScript types, then configured a new Google OAuth provider in the OAuth configuration with email and profile scopes.

Changes

Cohort / File(s) Summary
Dependencies Update
apps/meteor/package.json
Added passport-google-oauth20 (v^2.0.0) as runtime dependency and @types/passport-google-oauth20 (v^2) as dev dependency.
OAuth Configuration
apps/meteor/server/lib/oauth/oauthConfigs.ts
Added Google provider configuration to OAuthConfigs with GoogleStrategy and scopes for email and profile; updated Provider type to include google key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

type: feature, area: authentication

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Passport Google OAuth' directly relates to the main change: adding Google OAuth support via Passport packages and configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot

changeset-bot Bot commented Apr 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8cca8b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Apr 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.81%. Comparing base (be66f93) to head (8cca8b5).
⚠️ Report is 1 commits behind head on feat/phishing-resistant-mfa.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feat/phishing-resistant-mfa   #40222      +/-   ##
===============================================================
- Coverage                        69.83%   69.81%   -0.03%     
===============================================================
  Files                             3286     3286              
  Lines                           118862   118862              
  Branches                         21418    21394      -24     
===============================================================
- Hits                             83012    82979      -33     
- Misses                           32551    32583      +32     
- Partials                          3299     3300       +1     
Flag Coverage Δ
unit 70.53% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal
yash-rajpal marked this pull request as ready for review April 20, 2026 19:17
@yash-rajpal
yash-rajpal requested a review from a team as a code owner April 20, 2026 19:17
@coderabbitai coderabbitai Bot added type: feature Pull requests that introduces new feature area: authentication labels Apr 20, 2026
@yash-rajpal
yash-rajpal merged commit 4e185c8 into feat/phishing-resistant-mfa Apr 21, 2026
37 of 48 checks passed
@yash-rajpal
yash-rajpal deleted the passport-google branch April 21, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: authentication type: feature Pull requests that introduces new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants