feat: Voice call popup window - #40202
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
WalkthroughIntroduces a popout window mode for voice calls by refactoring the view-tracking context model from a single boolean to a multi-view registry, adding a window-management hook and HTML landing page generator, introducing three new popout UI components, updating existing views and providers to support multi-view rendering, and expanding E2E tests to cover widget, in-room, and popout interactions. ChangesVoice Call Popout Feature
Sequence Diagram(s)sequenceDiagram
participant User as User (main window)
participant RoomSection as MediaCallRoomSection
participant Widget as MediaCallWidget
participant ViewProvider as MediaCallViewProvider
participant Tracker as useAvailableViewTracker
participant Popout as MediaCallPopout
participant WinHook as usePopoutWindow
participant PopoutWin as voice-call-popup.html
participant PopoutUI as MediaCallPopoutWindow/View
rect rgba(70, 130, 180, 0.5)
Note over User,Widget: Widget/Room active (no popout)
RoomSection->>Tracker: registerView('room')
Widget->>Tracker: registerView('widget')
Tracker-->>Widget: currentViews=['widget'] (room filtered)
Widget-->>User: renders floating widget
end
rect rgba(100, 160, 100, 0.5)
Note over User,PopoutWin: User opens popout
User->>RoomSection: click "Open in new window"
RoomSection->>ViewProvider: onOpenPopout()
ViewProvider->>Tracker: registerView('popout')
Tracker-->>Widget: currentViews=['widget','popout']
Popout->>WinHook: openPopoutWindow(callId)
WinHook->>PopoutWin: window.open('/voice-call-popup.html')
WinHook-->>Popout: container {root, ownerDocument}
Popout->>PopoutUI: render MediaCallPopoutWindow
PopoutUI-->>PopoutWin: createPortal → MediaCallPopoutView
Widget-->>User: shows "Show call here" placeholder
end
rect rgba(180, 100, 100, 0.5)
Note over User,PopoutWin: User returns to main window
User->>PopoutUI: click "Return to main window"
PopoutUI->>ViewProvider: onClosePopout()
ViewProvider->>Tracker: unregisterView('popout')
Tracker-->>Widget: currentViews=['widget'] (room still filtered)
WinHook->>PopoutWin: closePopoutWindow()
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 4de6495 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dfea09d to
0b3dbf4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40202 +/- ##
===========================================
- Coverage 70.14% 70.12% -0.03%
===========================================
Files 3359 3360 +1
Lines 129609 129655 +46
Branches 22452 22459 +7
===========================================
+ Hits 90919 90923 +4
- Misses 35379 35422 +43
+ Partials 3311 3310 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9aefdbb to
9762a62
Compare
f87c005 to
81b45de
Compare
Proposed changes (including videos or screenshots)
Issue(s)
SSGA-4
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Release Notes