test(federation): reorganize display name change tests for clarity and consistency

[sampaiodiego]

…d consistency

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Task: FGA-61

Summary by CodeRabbit

Release Notes

This release contains updates to test infrastructure only. No end-user visible changes or new features are included in this update.

• Tests
  • Enhanced test reliability and cleanup procedures for direct message federation scenarios.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2d70c22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Reorganized the display name change test block within a federation test suite and modified its cleanup control flow. The new sequence resets the Synapse display name, waits for subscription state propagation, verifies the DM room name reflects the change, then deletes the Rocket.Chat user—reordering operations to stabilize state before teardown.

Changes

Cohort / File(s)	Summary
Test Reorganization & Cleanup Flow ee/packages/federation-matrix/tests/end-to-end/dms.spec.ts	Relocated describe('Display name changes') test block within the suite and restructured its afterAll cleanup: now resets Synapse display name first, adds retry-based wait to verify DM subscription fname reflects the reset state, and finally deletes the Rocket.Chat user. Functional assertion for room-name update after display name change remains.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: chore, area: authentication

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: reorganizing display name change tests in federation tests for improved clarity and consistency.
Linked Issues check	✅ Passed	The PR successfully reorganizes federation display name change tests as required by FGA-61, improving test structure and consistency through reordering and enhanced cleanup procedures.
Out of Scope Changes check	✅ Passed	All changes are within scope: the modifications focus exclusively on reorganizing and improving the display name change test block in the federation test suite.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.51%. Comparing base (58fc21c) to head (2d70c22).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40079      +/-   ##
===========================================
- Coverage    70.52%   70.51%   -0.02%     
===========================================
  Files         3271     3271              
  Lines       116804   116804              
  Branches     21066    21062       -4     
===========================================
- Hits         82376    82361      -15     
- Misses       32379    32388       +9     
- Partials      2049     2055       +6     

Flag	Coverage Δ
e2e	60.47% <ø> (-0.03%)	⬇️
e2e-api	48.04% <ø> (-0.08%)	⬇️
unit	70.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sampaiodiego]

/jira FGA-46

[dionisio-bot]

⚠️ Dionisio (Jira)

The milestone "8.4.0" does not exist on the Jira board; the task was created without Fix version.